feat(signature-type): add missing microsoft-defender signature types (#335) - #336
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
New public enum values were added without corresponding unit tests to lock in the expected string values and prevent regressions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds the missing SignatureTypes enum entries needed by the microsoft-defender collector so collectors and other components can share a consistent signature vocabulary.
Changes:
- Added
process_name,command_line,file_name,hostname,ipv4_address, andipv6_addresstoSignatureTypes. - Aligns the Python client’s signature type vocabulary with what
microsoft-defenderalready uses.
File summaries
| File | Description |
|---|---|
| pyoaev/signatures/types.py | Extends SignatureTypes with additional values required by microsoft-defender. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| SIG_TYPE_PROCESS_NAME = "process_name" | ||
| SIG_TYPE_PARENT_PROCESS_NAME = "parent_process_name" | ||
| SIG_TYPE_COMMAND_LINE = "command_line" | ||
| SIG_TYPE_IPV4_ADDRESS = "ipv4_address" | ||
| SIG_TYPE_IPV6_ADDRESS = "ipv6_address" |
Kakudou
left a comment
There was a problem hiding this comment.
LGTM, gonna need a real analysis of usage when we gonna rework that into a SDK :D.
Ty !
Proposed changes
microsoft-defenderTesting Instructions
Related issues
Checklist
Further comments