Skip to content

feat(signature-type): add missing microsoft-defender signature types (#335) - #336

Merged
guzmud merged 1 commit into
mainfrom
feat/335-add-missing-signature-type
Aug 6, 2026
Merged

feat(signature-type): add missing microsoft-defender signature types (#335)#336
guzmud merged 1 commit into
mainfrom
feat/335-add-missing-signature-type

Conversation

@guzmud

@guzmud guzmud commented Aug 6, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Adding missing signature types used by the collector microsoft-defender

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI lite review requested due to automatic review settings August 6, 2026 12:25
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

New public enum values were added without corresponding unit tests to lock in the expected string values and prevent regressions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Adds the missing SignatureTypes enum entries needed by the microsoft-defender collector so collectors and other components can share a consistent signature vocabulary.

Changes:

  • Added process_name, command_line, file_name, hostname, ipv4_address, and ipv6_address to SignatureTypes.
  • Aligns the Python client’s signature type vocabulary with what microsoft-defender already uses.
File summaries
File Description
pyoaev/signatures/types.py Extends SignatureTypes with additional values required by microsoft-defender.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment on lines +49 to +53
SIG_TYPE_PROCESS_NAME = "process_name"
SIG_TYPE_PARENT_PROCESS_NAME = "parent_process_name"
SIG_TYPE_COMMAND_LINE = "command_line"
SIG_TYPE_IPV4_ADDRESS = "ipv4_address"
SIG_TYPE_IPV6_ADDRESS = "ipv6_address"

@Kakudou Kakudou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gonna need a real analysis of usage when we gonna rework that into a SDK :D.

Ty !

@guzmud
guzmud merged commit 588324c into main Aug 6, 2026
15 of 16 checks passed
@guzmud
guzmud deleted the feat/335-add-missing-signature-type branch August 6, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(signature-types): adding signature types used in microsoft-defender

4 participants