Skip to content

fix(signatures): execution message repeats the action instead of the status #385

Open

Description

Description

ExecutionDetails.execution_message (pyoaev/signatures/models.py) builds Current action: {action} - Current status: {status} but takes status from execution_action, so every signature callback leaves a trace like Current action: data - Current status: data.

action = self.execution_action.value if self.execution_action else "unknown"
status = self.execution_action.value if self.execution_action else "unknown"  # should be execution_status

Environment

  1. OS: any
  2. Version: pyoaev 3.261118.0 (main be71fb0)
  3. Other environment details: seen on the email-smtp injector's signature callback

Reproducible steps

  1. Run an injector that sends signatures (email-smtp).
  2. Open the inject's execution traces.

Expected output

Current action: <action> - Current status: <status>.

Actual output

Current action: data - Current status: data.

Additional information

One-line fix: read self.execution_status for status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugType: something isn't working (fix:).needs triageNeeds triage from the Filigran product team.

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions