Repository navigation
feat: add optional accessible editor guide - #13
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace rover-specific inline guidance with an optional five-step Guide available for any open project. The guide highlights editor controls, explains how to reveal hidden Explorer/model controls, exposes step descriptions through a polite live region, and preserves drafts, layout and project data.
Keep focus on controls chosen outside the guide, while returning focus to Guide after Escape, Close or Done. Include focused browser regressions, updated documentation and visual baselines for the new header and removal of inline rover notes.
Validation
npm run check: passed formatting, architecture, TypeScript, 160 Vitest tests and 10 Node checks.npm run test:e2e -- --project=functional editor-tour.spec.ts: 4 passed with real pinned engines and a fresh production build.npm run test:e2e -- --project=visual: 80 passed, 1 failed. All four guide screenshots passed without baseline updates during review. The narrow light requirements screenshot differed by 1,907 pixels; an isolated fresh-build rerun passed without code or baseline changes. The intermittent cause remains unresolved and is recorded indocs/verification.md.These are local results; hosted CI is separate.