Repository navigation
fix(referee): re-record baselines for the DocumentQueries library change - #1691
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
WhereType gained a defaulted exact parameter, which moved the opensysml-libraries input digest of both committed baselines and, in the api-json differential, the InvocationExpression.parameter and .input rows for the 34 WhereType calls under examples/ and docs/manual/examples. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
4 of 6 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
developis red atade03595d:TestCommittedBaselineStatesThisRepositorysProvenancefails intools/referee/apijsonandtools/referee/diff(CI jobGo race tests (rest), also the quick tier) with#1689 (
WhereType exact) gaveDocumentQueries::WhereTypea newin exact : Boolean[1] default false;parameter, which changedinternal/workspace/libs/stdlib/OpenSysML Libraries/DocumentQueries.sysml, theopensysml-librariesinput root of both committed baselines, without re-recording them. This PR re-records the two baselines with the repo's own tools and re-states the three figures indocs/project/api-json-differential.mdthat the re-record moved. No code changes.Follow-up for the queue: open PR #1690 (
Differ) changes the same libs files again, so after this PR lands #1690 must mergedevelopand re-record both baselines once more.What moved
docs/project/pilot-differential-baseline.jsonprovenance.inputs[opensysml-libraries].digest:sha256:ac6a1e3b…→sha256:29a3bf0f…;provenance.recorded2026-10-28 → 2026-10-29. Nothing else: 8 roots / 9 inputs as before, no file row, count or total moved (921 files, 519 fully agreeing; 1098 agreed, 359 only ours, 2462 only the pilot's).docs/project/api-json-differential-baseline.jsonprovenance.inputs[opensysml-libraries].digest: same move; 9 roots / 10 inputs as before.InvocationExpression.parameter: 382 / 98 → 348 / 132InvocationExpression.input: 368 / 96 → 334 / 130elements,oursMissing,pilotMissing,absentBoth,indeterminate,pilotNondeterministicunchanged):examples: present-equal 332702 → 332672, present-different 8290 → 8320 (15WhereType(calls:self-model/document.sysml8,analysis-results-demo/lander-results.sysml6,external-tool-demo/thermal.sysml1 — 15 × 2 properties = 30);pilotLibraryElements15571 → 15648 (+77 = 7 files × 11)manual-examples: present-equal 88779 → 88741, present-different 2034 → 2072 (19WhereType(calls:cookbook.sysml8,requirements.sysml3,trace-4-program.sysml2,traceability.sysml2,observatory.sysml1,trace-1-basic.sysml1,trace-2-hierarchy.sysml1,trace-3-derivation.sysml1 — 19 × 2 = 38);pilotLibraryElements17088 → 17209 (+121 = 11 files × 11)pilotLibraryElements37415 → 37613. The other seven roots did not move.Why those objects, and whose effect it is. Checked directly by exporting
examples/external-tool-demo/thermal.sysmlwith the pinned pilot once against the pre-#1689 library and once against the current one. For theWhereType(...)call (Reporting::ThermalRuns/InvocationExpression[0]/Feature[0]/InvocationExpression[0]) the pilot'sparameterlist grew 3 → 4 andinput2 → 3: the pilot synthesizes an implicit parameter for the defaultedexacteven though the call does not pass it, while our writer lists only the parameters the call binds (3 / 2, unchanged). So each of the 34WhereTypecalls moved those two properties from present-equal to present-different. That is the direct consequence of #1689's new defaulted parameter landing on a pre-existing writer gap (we do not emit implicit parameters for defaulted arguments the call leaves out; theProject(...)calls in the same files already show it), not develop drift. ThepilotLibraryElementsgrowth is the 11 new library elements the pilot writes for every file that loadsDocumentQueries(WhereType::exactReferenceUsage, its FeatureTyping, FeatureValue, LiteralBoolean, MultiplicityRange + LiteralInteger, the new Comment and the four memberships), identical per file.docs/project/api-json-differential.mdexamples(332702 / 8290 → 332672 / 8320) anddocs/manual/examples(88779 / 2034 → 88741 / 2072). No other row, prose orpilot-differential.mdfigure moved (make docs-countsreports both current).How it was verified
Provisioned every input root first (
download-spec-examples,download-pilot-corpora,download-training-examples,download-pilot-kerml-validator,download-pilot-sysml-validator,download-pilot-json-exporter), then:Gate on the branch:
Checklist
make testandmake lintpass locally (the gate above; no Go code changed)docs/project/api-json-differential.md)make docs-countsrunLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/02c00bfac5574bdb91cc5179ca1fc86c
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/02c00bfac5574bdb91cc5179ca1fc86c?variant=devin
Requested by: @HuiJun