Repository navigation
chore(engine-contract): list DocumentQueries::Differ, bound by OpenSysML's query planner - #17
Merged
Merged
Conversation
…sML's query planner Co-Authored-By: Nicolas Rouquette <nicolas.f.rouquette@jpl.nasa.gov>
Co-Authored-By: Nicolas Rouquette <nicolas.f.rouquette@jpl.nasa.gov>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open-MBEE/OpenSysML#1690 binds
DocumentQueries::Differ(declared by #16) ininternal/ir/queryplan/compiler.go, and OpenSysML's hygiene gateTestEngineContractCoversEveryBoundNamerequires every bound name to be inengine-contract.json— "new engine bindings are added to the manifest by the OpenSysML-side pull request that introduces them — upstream there first" (CONTRIBUTING, The engine contract). This adds the entry, kinddocument, consumerinternal/ir/queryplan/compiler.go, in name order;scripts/check-engine-contract.pypasses.Semver impact: PATCH. Additive manifest entry;
contractstays 1 (a bump is for changing or removing an entry). No library source changes.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/18ad47adf36f44e9b6824a4472f9678d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/18ad47adf36f44e9b6824a4472f9678d?variant=devin
Requested by: @NicolasRouquette