Draft
Conversation
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
mmichal10
reviewed
Oct 15, 2025
| dirty_ratio_test_threshold = random.randint(0, 100) | ||
|
|
||
| with TestRun.step("Disable cache cleaning"): | ||
| cache.set_seq_cutoff_policy(SeqCutOffPolicy.never) |
Contributor
There was a problem hiding this comment.
Cutoff has been set to never in :322
| .read_write(ReadWrite.randwrite) | ||
| ) | ||
|
|
||
| dirty_ratio_test_threshold = random.randint(0, 100) |
Contributor
There was a problem hiding this comment.
Picking a random threshold doesn't guarante that the corner cases with threshold=0 and threshold=100 are tested. Instead of 10 random iterations I suggest 3 predefined cases with both corner cases and and one value from the middle of the range.
Contributor
There was a problem hiding this comment.
There could also be another testcase to check the behavior when decreasing and increasing the threshold when the flush is in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.