Skip to content

CI runs the OKF reference check, where a skip fails - #9

Merged
tmoosting merged 2 commits into
mainfrom
okf-reference-ci
Nov 17, 2026
Merged

tmoosting merged 2 commits into
mainfrom
okf-reference-ci

Conversation

@tmoosting

Copy link
Copy Markdown
Member

tests/test_okf.py reads the export with OKF's own parser and viewer at the commit onlyworlds.okf pins, and skips when that code is not importable. No CI job had it, so the check never ran in CI.

A new job fetches OKF's repository at the pinned commit (read from the module, so the pin stays one line) and fails unless the test passes: a skip is a failure there.

🤖 Generated with Claude Code

tmoosting and others added 2 commits November 17, 2026 07:06
tests/test_okf.py reads the export with OKF's own parser and viewer at the
commit onlyworlds.okf pins, and skips when that code is not importable. No CI
job had it, so the check never ran there. A new job fetches OKF's repository
at the pinned commit, read from the module so the pin stays one line, and
fails unless the test passes.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Since 0.74.1 the export writes an in-prose reference as a link to the
element's concept, and OKF's viewer draws an edge for it. The check still
expected one edge per link field's pair, 53 on the example world where the
viewer draws 56, and nothing showed it: the check skips wherever OKF's code is
not importable, which was everywhere it ran. Its first run in CI failed on
that count. The expected pairs now include each in-prose reference, read from
the source's own text.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@tmoosting
tmoosting merged commit ac8f2f4 into main Nov 17, 2026
9 checks passed
@tmoosting
tmoosting deleted the okf-reference-ci branch November 17, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant