Repository navigation
CI runs the OKF reference check, where a skip fails - #9
Merged
Merged
Conversation
tests/test_okf.py reads the export with OKF's own parser and viewer at the commit onlyworlds.okf pins, and skips when that code is not importable. No CI job had it, so the check never ran there. A new job fetches OKF's repository at the pinned commit, read from the module so the pin stays one line, and fails unless the test passes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Since 0.74.1 the export writes an in-prose reference as a link to the element's concept, and OKF's viewer draws an edge for it. The check still expected one edge per link field's pair, 53 on the example world where the viewer draws 56, and nothing showed it: the check skips wherever OKF's code is not importable, which was everywhere it ran. Its first run in CI failed on that count. The expected pairs now include each in-prose reference, read from the source's own text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_okf.py reads the export with OKF's own parser and viewer at the commit onlyworlds.okf pins, and skips when that code is not importable. No CI job had it, so the check never ran in CI.
A new job fetches OKF's repository at the pinned commit (read from the module, so the pin stays one line) and fails unless the test passes: a skip is a failure there.
🤖 Generated with Claude Code