Repository navigation
CI runs the suite against the built wheel - #17
Merged
Merged
Conversation
The gates job tests the source tree, installed editable, while PyPI gets the wheel: a file the build leaves out passes there and fails for every user. A wheel job builds it on Python 3.12, checks it holds every tracked file of the package and nothing else, installs it into the locked dev environment in place of the project, asserts the import comes from site-packages, and runs the whole suite. Watched failing: a wheel built without the vendored folder checker fails the contents check (three files named) and the suite (FileNotFoundError), where the source run passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gates job tests the source tree, installed editable, but PyPI gets the wheel. A file the build leaves out would pass there and fail for every user, and PyPI keeps every version.
wheeljob builds the wheel on Python 3.12 (the floor). It checks the wheel holds every tracked file undersrc/onlyworldsand nothing else. It installs the wheel into the locked dev environment in place of the project, assertsonlyworldsimports from site-packages, and runs the whole suite._walkexcluded fails the contents check, which names the three files, and the suite, with a FileNotFoundError. The source run passes on the same tree. On the clean build: 63 of 63 files, 2156 passed against the wheel.🤖 Generated with Claude Code