Skip to content

chore: [SDK-4197] migrate to Vite+ toolchain#1928

Merged
fadi-george merged 7 commits intomainfrom
fadi/sdk-4197-add-vite-to-rn
Mar 20, 2026
Merged

chore: [SDK-4197] migrate to Vite+ toolchain#1928
fadi-george merged 7 commits intomainfrom
fadi/sdk-4197-add-vite-to-rn

Conversation

@fadi-george
Copy link
Collaborator

Description

One Line Summary

Migrate the build, lint, and test toolchain from Bun + Jest + ESLint + Prettier to Vite+ (vp) which bundles Vitest, Oxlint, and Oxfmt.

Details

Motivation

Vite+ provides a unified toolchain that replaces multiple separate tools (Bun, Jest, ESLint, Prettier) with a single CLI (vp). This simplifies dependency management, reduces config files, and aligns with the direction of other OneSignal SDK wrappers.

Scope

  • Build: vp pack replaces the previous build setup
  • Tests: Vitest (via vp test) replaces Jest
  • Linting: Oxlint (via vp check) replaces ESLint
  • Formatting: Oxfmt (via vp fmt) replaces Prettier
  • CI/CD: Updated to use shared wrapper-js-ci.yml with toolchain: vite-plus and publish-npm-github.yml with toolchain: vite-plus
  • Demo app: Removed eslint, prettier, and jest config/dependencies (not needed for the example app)
  • No changes to runtime behavior, public API, or native code

Testing

Unit testing

All existing tests migrated to Vitest and passing via vp test.

Manual testing

  • Verified vp check (lint), vp test (tests), and vp pack (build) all pass locally
  • Verified demo app builds and runs on both Android emulator and iOS simulator

Affected code checklist

  • Notifications
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

@fadi-george fadi-george requested a review from a team as a code owner March 20, 2026 17:00
@fadi-george fadi-george merged commit aafffef into main Mar 20, 2026
6 of 7 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4197-add-vite-to-rn branch March 20, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants