feat: add Huawei and email_reply_to_address parameters to Notification#73
Merged
sherwinski merged 1 commit intomainfrom Mar 24, 2026
Merged
feat: add Huawei and email_reply_to_address parameters to Notification#73sherwinski merged 1 commit intomainfrom
sherwinski merged 1 commit intomainfrom
Conversation
onesignal-deploy
force-pushed
the
user-api-updates
branch
2 times, most recently
from
4019c00 to
d27eb61
Compare
onesignal-deploy
force-pushed
the
user-api-updates
branch
from
d27eb61 to
8a5dfca
Compare
onesignal-deploy
force-pushed
the
user-api-updates
branch
from
8a5dfca to
d9d4ca8
Compare
sherwinski
force-pushed
the
user-api-updates
branch
from
d9d4ca8 to
d122df9
Compare
sherwinski
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+50
to
+119
| name: Publish to Maven Central | ||
| needs: release | ||
| if: needs.release.outputs.new_release_published == 'true' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }} | ||
| MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }} | ||
| SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }} | ||
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | ||
| GPG_FILE_NAME: onesignal_sdk_gpg_subkeys.gpg | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Java | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'temurin' | ||
|
|
||
| - name: Cache Gradle packages | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.gradle/caches | ||
| ~/.gradle/wrapper | ||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-gradle- | ||
|
|
||
| - name: Grant execute permission for gradlew | ||
| run: chmod +x gradlew | ||
|
|
||
| - name: Set version from input | ||
| if: github.event.inputs.version != '' | ||
| run: | | ||
| echo "VERSION=${{ github.event.inputs.version }}" >> $GITHUB_ENV | ||
| sed -i "s/version = '[^']*'/version = '${{ github.event.inputs.version }}'/" build.gradle | ||
|
|
||
| - name: Build project | ||
| run: ./gradlew build | ||
|
|
||
| - name: Run tests | ||
| run: ./gradlew test | ||
|
|
||
| - name: Decode GPG file from secret | ||
| run: | | ||
| echo "${{ secrets.SIGNING_SECRET_KEY_RING_FILE }}" | base64 -d > "$GPG_FILE_NAME" | ||
| echo "GPG_FILE_PATH=$(pwd)/$GPG_FILE_NAME" >> $GITHUB_ENV | ||
|
|
||
| - name: Verify GPG file | ||
| run: | | ||
| ls -lh "$GPG_FILE_PATH" | ||
| gpg --list-packets "$GPG_FILE_PATH" || echo "Invalid key file!" | ||
|
|
||
| - name: Publish to Maven Central | ||
| run: | | ||
| ./gradlew publishAndReleaseToMavenCentral --no-configuration-cache \ | ||
| -PmavenCentralUsername="$MAVEN_CENTRAL_USERNAME" \ | ||
| -PmavenCentralPassword="$MAVEN_CENTRAL_PASSWORD" \ | ||
| -Psigning.keyId="$SIGNING_KEY_ID" \ | ||
| -Psigning.password="$SIGNING_PASSWORD" \ | ||
| -Psigning.secretKeyRingFile="$GPG_FILE_PATH" | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: build-artifacts | ||
| path: build/libs/ |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
In general, fix this by explicitly setting minimal permissions for jobs that use the default GITHUB_TOKEN, instead of relying on repo defaults. For jobs that only need to read the repository (or not use the token at all), set contents: read at the job or workflow level; only grant write scopes where strictly required.
For this workflow, the release job already has a permissions block. The publish job (lines 49–120) does not, so we should add an explicit permissions block under publish:. The steps in publish only require cloning the code and uploading artifacts; both can work with a read‑only contents permission. Therefore, the best fix is to add:
permissions:
contents: readright below the existing runs-on: ubuntu-latest line in the publish job. This preserves all existing behavior while ensuring the GITHUB_TOKEN used in this job is limited to read‑only access to repository contents. No additional imports, methods, or definitions are needed, since this is purely a YAML configuration change.
Suggested changeset
1
.github/workflows/release.yml
| @@ -51,6 +51,8 @@ | ||
| needs: release | ||
| if: needs.release.outputs.new_release_published == 'true' | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| env: | ||
| MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }} | ||
| MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }} |
Copilot is powered by AI and may make mistakes. Always verify output.
sherwinski
changed the title
email_reply_to_address parameters to Notification
sherwinski
approved these changes
Mar 24, 2026
sherwinski
force-pushed
the
user-api-updates
branch
from
7bb3637 to
e01cee1
Compare
sherwinski
changed the title
email_reply_to_address parameters to Notification
sherwinski
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
## [5.3.0](v5.2.0...v5.3.0) (2026-03-24) ### Features * add Huawei and email_reply_to_address parameters to Notification ([#73](#73)) ([62dc9fc](62dc9fc)) [skip ci]
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Adds the following
Notificationparameters:huawei_badge_classhuawei_badge_add_numhuawei_badge_set_numhuawei_categoryhuawei_bi_tagemail_reply_to_address