chore: [SDK-5114] drop unused swiftVersion after KMP bump - #1729
Merged
Conversation
The shared logger contract no longer has swiftVersion. Pin the submodule to the merge of KMP #22 and remove the always-nil host stub. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: SDK-5114
Consume OneSignal-KMP-SDK#22 and drop the always-nil
swiftVersionstub fromOSLoggerPlatformProvider. The shared contract no longer has that property;ossdk.swift_versionstays reserved so extras cannot smuggle it back.kotlinVersionis unchanged.Pin
Submodule
87e87fd(v0.3.0) →6c6bb90(KMPmain). That walk includes two already-merged KMP commits on the way to #22:swiftVersionNative iOS crash-cache bounding stays on #1725. If this lands first, #1725 should fast-forward its gitlink to
6c6bb90(or later) rather than rewind it.Test plan
OneSignalOSCoreTests107 passing, 0 failures, against the new pinswiftlintclean on the changed source file6c6bb90Made with Cursor