Skip to content

fix: [SDK-5581] catch Throwable around the startup timeline log #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulraqeeb33 merged 1 commit into from
Oct 22, 2026
Merged

fix: [SDK-5581] catch Throwable around the startup timeline log #2812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ internal class OneSignalImp : IOneSignal,
private fun reportStartupTimeline() {
try {
if (StartupTimeline.claimReport()) Logging.info("OneSignal: ${StartupTimeline.summary()}")
} catch (_: RuntimeException) {
} catch (_: Throwable) {
}
}

Expand Down
3 changes: 2 additions & 1 deletion ...alSDK/onesignal/core/src/test/java/com/onesignal/common/threading/StartupTimelineTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import io.kotest.matchers.string.shouldEndWith
import io.kotest.matchers.string.shouldNotContain
import kotlinx.coroutines.CompletableDeferred
import org.robolectric.shadows.ShadowSystemClock
import java.io.IOException
import java.time.Duration
import java.util.concurrent.CopyOnWriteArrayList
import kotlin.concurrent.thread
Expand Down Expand Up @@ -161,7 +162,7 @@ class StartupTimelineTests : FunSpec({
val os = OneSignalImp()
os.setField("initState", InitState.IN_PROGRESS)
os.setField("suspendCompletion", CompletableDeferred<Unit>())
val listener = ILogListener { if (it.entry.contains("startup_timeline")) throw IllegalStateException("customer") }
val listener = ILogListener { if (it.entry.contains("startup_timeline")) throw IOException("customer") }
Logging.addListener(listener)
try {
os.method("completeInit", InitState::class.java).invoke(os, InitState.SUCCESS)
Expand Down
Loading