-
Notifications
You must be signed in to change notification settings - Fork 376
fix: end initialization early if device storage is locked #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Diff Coverage ReportDiff Coverage ReportThreshold: 80% Changed Files Coverage
Overall Coverage66/379 lines covered (17.4%) ❌ Coverage Check FailedFiles below 80% threshold:
|
0c270f6 to
7ec8687
Compare
| initState = InitState.FAILED | ||
| notifyInitComplete() | ||
| return false | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part can be in a separate function
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we discussed on the call and this seems to be a good solution.
Only the diff coverage has failed. but the tests have passed
Description
One Line Summary
Add isDeviceStorageUnlocked check to avoid accessing user data before the device is unlocked on Android 7.0+, and end initialization early if device storage is locked.
Details
Motivation
This allows the SDK to avoid reading/writing user data too early (e.g., in boot receivers or early background services), and to avoid crashes with the inconsistent state.
Scope
Terminate the initialization early depends on user storage availability.
Testing
Unit testing
Two test cases are added.
Manual testing
Tested on Emulator Pixel 9 API 35
Step to reproduce:
<receiver android:name="com.onesignal.notifications.receivers.BootUpReceiver" android:exported="true" android:directBootAware="true"> <intent-filter> <action android:name="android.intent.action.BOOT_COMPLETED" /> <action android:name="android.intent.action.QUICKBOOT_POWERON" /> <action android:name="android.intent.action.LOCKED_BOOT_COMPLETED"/> </intent-filter> </receiver>adb logcat | grep -E "(SharedPreferences|BootUpReceiver)"
After fix:
The exception is no longer thrown in the background. After the user has unlocked the device, notifications can be received and interacted as normal even the app is not opened.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is