feat: promote greenfield workspace into mainline taskers#4
feat: promote greenfield workspace into mainline taskers#4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a231f29f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| agent, | ||
| title, | ||
| message, | ||
| CliSignalKind::Completed, |
There was a problem hiding this comment.
Preserve error kind for agent-hook stop events
agent-hook stop is always emitted as CliSignalKind::Completed, so any caller that uses stop for failures will record a success state. The shell hook scripts route error into this path, which means non-zero command exits lose error attention and appear completed in activity/agent state views.
Useful? React with 👍 / 👎.
| cwd: None, | ||
| repo_name: None, | ||
| git_branch: None, | ||
| ports: Vec::new(), |
There was a problem hiding this comment.
Avoid clearing pane metadata in agent-hook signals
This metadata payload hard-codes cwd, repo_name, and git_branch to None; AppModel::apply_surface_signal assigns incoming metadata fields directly, so each agent-hook event clears previously known repo/cwd/branch context for the surface. In practice, started/progress/waiting/stop updates can blank repo hints and branch info until a later full metadata snapshot arrives.
Useful? React with 👍 / 👎.
Summary
taskers-oldwhile retargeting launcher, scripts, CI, and docs to the new mainline appValidation