Remove logging statements for cleaner code#18
Merged
saurabh-featherhq merged 2 commits intomainfrom Oct 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR removes all LoggerProxy logging statements from three workflow execution functions, reverting the logging infrastructure that was added in PR #15.
Key Changes:
- Removed
LoggerProxyimport from all three operation files - Eliminated all
Logger.info()calls that tracked operation progress and parameter values - Removed all
Logger.error()calls in error handling blocks - Error throwing behavior remains unchanged - errors are still properly propagated
Context:
The logging was originally added in commit 97ce507 to replace console.log statements with proper n8n logging. This PR now removes that logging entirely, suggesting a preference for cleaner code without verbose operational logging in these workflow functions.
Confidence Score: 5/5
- This PR is safe to merge with no risk
- The changes only remove logging statements without altering any business logic, error handling, or control flow. All error throwing mechanisms remain intact, ensuring proper error propagation to n8n's error handling system. The removal is consistent across all three files and only affects observability, not functionality.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| nodes/Feather/operations/cancelWorkflowExecution.ts | 5/5 | Removed all Logger statements (info and error) and LoggerProxy import, simplifying error handling flow |
| nodes/Feather/operations/createAgentWorkflow.ts | 5/5 | Eliminated extensive logging throughout workflow creation process, removing LoggerProxy import and all info/error statements |
| nodes/Feather/operations/createWorkflowExecution.ts | 5/5 | Removed all logging statements and LoggerProxy import, maintaining validation and error throwing logic |
Sequence Diagram
sequenceDiagram
participant Client as n8n Client
participant Node as Feather Node
participant API as Feather API
Note over Client,API: Workflow Execution Operations
alt Create Workflow Execution
Client->>Node: executeCreateWorkflowExecution()
Node->>Node: Validate parameters (zipcode/state)
Node->>Node: Build request body with metadata
Node->>API: POST /workflow/{id}/execution
API-->>Node: Execution response
Node-->>Client: Return execution data
end
alt Create Agent Workflow
Client->>Node: executeCreateAgentWorkflow()
Node->>Node: Parse workflow & TCPA schedules
Node->>Node: Build workflow definition
Node->>API: POST /workflow
API-->>Node: Workflow response
Node-->>Client: Return workflow data
end
alt Cancel Workflow Execution
Client->>Node: executeCancelWorkflowExecution()
Node->>Node: Get workflowId & executionId
Node->>API: POST /workflow/{id}/executions/{executionId}/cancel
API-->>Node: Cancellation response
Node-->>Client: Return cancellation data
end
3 files reviewed, no comments
…n functions for improved readability
saurabh-featherhq
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate unnecessary logging in workflow execution functions to enhance code clarity and maintainability.