Fix fat jar build and update dependencies#146
Open
TheMeinerLP wants to merge 1 commit into
Open
Conversation
…n CI - Pin net.minestom:minestom to 2026.05.17-1.21.11 (current Maven Central release) instead of the BOM-resolved version so the deployable jar runs on the latest Minestom regardless of aonyx/mycelium BOM lag. - Bump butterfly 1.0.21 -> 1.0.23 to match the current Butterfly release. - Harden the application shadowJar: strip jar signatures and module-info and exclude duplicates so the relocation-free fat jar built from the shaded LuckPerms fork stays loadable. - Pin the reusable PR/publish workflows to the v2.1.0 release tag instead of a temporary branch ref. https://claude.ai/code/session_01S76fk9ma5Szkf9r1W44RVP
Job Summary for GradleBuild PR :: build
|
2 similar comments
Job Summary for GradleBuild PR :: build
|
Job Summary for GradleBuild PR :: build
|
Test results12 files 12 suites 7s ⏱️ Results for commit d58cdd0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues with the fat jar build process and updates project dependencies to their latest versions.
Key Changes
META-INF/*.SF,META-INF/*.DSA,META-INF/*.RSA)module-info.class,META-INF/versions/**/module-info.class)duplicatesStrategy = DuplicatesStrategy.EXCLUDEto handle duplicate entries1.0.21→1.0.232026.05.17-1.21.11v2.1.0for both build and publish workflowsImplementation Details
The fat jar exclusions specifically target artifacts pulled by LuckPerms'
commonmodule that contain signed JARs and multi-release JAR metadata. These were causing conflicts in the final application JAR. TheduplicatesStrategysetting ensures consistent handling of any remaining duplicate entries during the merge process.https://claude.ai/code/session_01S76fk9ma5Szkf9r1W44RVP