Skip to content

Update dependency net.onelitefeather:mycelium-bom to v1.6.7 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update dependency net.onelitefeather:mycelium-bom to v1.6.7 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad92c35
Update dependency net.onelitefeather:mycelium-bom to v1.6.7
renovate[bot] May 25, 2026
fc9e2ed
fix(i18n): remove old translation registry and update test cases
theEvilReaper May 26, 2026
1b37e7b
fix(deps): add slf4j dependency to avoid compile issues
theEvilReaper May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ configurations.all {

dependencies {
implementation(platform(libs.mycelium.bom))
implementation(libs.slf4j.api)
compileOnly(libs.adventure)
compileOnly(libs.minestom)

Expand Down
6 changes: 5 additions & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ dependencyResolutionManagement {
}
versionCatalogs {
create("libs") {
version("bom", "1.6.4")
version("bom", "1.6.7")
version("slf4j", "2.0.18")

library("mycelium.bom", "net.onelitefeather", "mycelium-bom").versionRef("bom")

library("slf4j.api", "org.slf4j", "slf4j-api").versionRef("slf4j")
library("minestom","net.minestom", "minestom").withoutVersion()
library("adventure", "net.kyori", "adventure-text-minimessage").withoutVersion()
library("cyano", "net.onelitefeather", "cyano").withoutVersion()
Expand Down
171 changes: 0 additions & 171 deletions src/main/java/net/theevilreaper/aves/i18n/AvesTranslationRegistry.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/main/java/net/theevilreaper/aves/inventory/pageable/PlayerPageableInventoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ private void updateMaxPages() {
*/
@Override
public void unregister() {
Set<Player> viewers = this.builder.getInventory().getViewers();
Set<? extends Player> viewers = this.builder.getInventory().getViewers();
//Check if the inventory contains viewer and when close the inventories for the viewers to prevent issue
if (!viewers.isEmpty()) {
viewers.forEach(Player::closeInventory);
Expand Down
27 changes: 0 additions & 27 deletions src/test/java/net/theevilreaper/aves/inventory/GlobalTranslatedInventoryBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
package net.theevilreaper.aves.inventory;

import net.theevilreaper.aves.i18n.AvesTranslationRegistry;
import net.theevilreaper.aves.i18n.TextData;
import net.kyori.adventure.key.Key;
import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer;
import net.kyori.adventure.translation.GlobalTranslator;
import net.kyori.adventure.translation.TranslationRegistry;
import net.minestom.server.inventory.InventoryType;
import net.minestom.testing.Env;
import net.minestom.testing.extension.MicrotusExtension;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import java.text.MessageFormat;
import java.util.Locale;

import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
Expand All @@ -34,22 +25,4 @@ void testGlobalTranslatedBuilder() {
assertNull(builder.getDataLayout());
}

@Test
void testGlobalTranslatedBuilderWithRegistry(Env env) {
TranslationRegistry translationRegistry = TranslationRegistry.create(Key.key("test", "test"));
translationRegistry.register("title", Locale.ENGLISH, new MessageFormat("TEST"));
GlobalTranslator.translator().addSource(new AvesTranslationRegistry(translationRegistry));

var builder = new GlobalTranslatedInventoryBuilder(InventoryType.CHEST_2_ROW);

builder.setTitleData(new TextData("title"));
builder.setLayout(InventoryLayout.fromType(builder.getType()));
String serialize = PlainTextComponentSerializer.plainText().serialize(builder.getInventory(Locale.ENGLISH).getTitle());
assertTrue(serialize.equalsIgnoreCase("TEST"));
assertNotNull(builder.getTitleData());
assertNotNull(builder.getLayout());
assertNull(builder.getDataLayout());
}


}
47 changes: 0 additions & 47 deletions src/test/java/net/theevilreaper/aves/item/TranslatedItemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,16 @@
package net.theevilreaper.aves.item;

import net.minestom.server.component.DataComponents;
import net.theevilreaper.aves.i18n.AvesTranslationRegistry;
import net.theevilreaper.aves.inventory.util.InventoryConstants;
import net.kyori.adventure.key.Key;
import net.kyori.adventure.text.Component;
import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer;
import net.kyori.adventure.translation.GlobalTranslator;
import net.kyori.adventure.translation.TranslationRegistry;
import net.minestom.server.item.ItemStack;
import net.minestom.server.item.Material;
import org.junit.jupiter.api.Test;

import java.text.MessageFormat;
import java.util.List;
import java.util.Locale;

import static org.junit.jupiter.api.Assertions.*;

class TranslatedItemTest {

@Test
void testRendererAves() {
var item = TranslatedItem.of(ItemStack.of(Material.ACACIA_BUTTON));
item.setDisplayName("key", "Argument 1", "Argument 2");
TranslationRegistry translationRegistry = TranslationRegistry.create(Key.key("test", "test"));
translationRegistry.register("key", Locale.ENGLISH, new MessageFormat("<arg:0> <arg:1>"));
GlobalTranslator.translator().addSource(new AvesTranslationRegistry(translationRegistry));
Component displayName = item.get(Locale.ENGLISH).get(DataComponents.CUSTOM_NAME);
assertNotNull(displayName);
assertTrue(PlainTextComponentSerializer.plainText().serialize(displayName).equalsIgnoreCase("Argument 1 Argument 2"));
}

@Test
void testRenderer() {
var item = TranslatedItem.of(ItemStack.of(Material.ACACIA_BUTTON));
item.setDisplayName("key", "Argument 1", "Argument 2");
TranslationRegistry translationRegistry = TranslationRegistry.create(Key.key("test", "test"));
translationRegistry.register("key", Locale.ENGLISH, new MessageFormat("{0} {1}"));
GlobalTranslator.translator().addSource(translationRegistry);
Component displayName = item.get(Locale.ENGLISH).get(DataComponents.CUSTOM_NAME);
assertNotNull(displayName);
assertTrue(PlainTextComponentSerializer.plainText().serialize(displayName).equalsIgnoreCase("Argument 1 Argument 2"));
}

@Test
void testRendererLore() {
var item = TranslatedItem.of(ItemStack.of(Material.ACACIA_BUTTON));
item.setDisplayName("key", "Argument 1", "Argument 2");
item.setLore("key", "Argument 1", "Argument 2");
TranslationRegistry translationRegistry = TranslationRegistry.create(Key.key("test", "test"));
translationRegistry.register("key", Locale.ENGLISH, new MessageFormat("{0} {1}"));
GlobalTranslator.translator().addSource(translationRegistry);
List<Component> lore = item.get(Locale.ENGLISH).get(DataComponents.LORE);
assertNotNull(lore);
assertFalse(lore.isEmpty());
assertLinesMatch(lore.stream().map(PlainTextComponentSerializer.plainText()::serialize).toList(), List.of("Argument 1 Argument 2"));
}

@Test
void testSetterMethods() {
var item = TranslatedItem.of(ItemStack.of(Material.ACACIA_BUTTON));
Expand Down
Loading