fix: improve memory safety and cleanup in Skeleton component

.claude/commands/commit.md

@@ -0,0 +1,161 @@
+# Claude Command: Commit
+
+This command helps you create well-formatted commits with conventional commit messages.
+
+## Usage
+
+To create a commit, just type:
+```
+/commit
+```
+
+Or with options:
+```
+/commit --no-verify
+```
+
+## What This Command Does
+
+1. Unless specified with `--no-verify`, automatically runs pre-commit checks:
+   - `yarn lint` to ensure code quality
+2. Checks which files are staged with `git status`
+3. If 0 files are staged, automatically adds all modified and new files with `git add`
+4. Performs a `git diff` to understand what changes are being committed
+5. Analyzes the diff to determine if multiple distinct logical changes are present
+6. If multiple distinct changes are detected, suggests breaking the commit into multiple smaller commits
+7. For each commit (or the single commit if not split), creates a commit message using conventional commit format
+
+## Best Practices for Commits
+
+- **Verify before committing**: Ensure code is linted, builds correctly, and documentation is updated
+- **Atomic commits**: Each commit should contain related changes that serve a single purpose
+- **Split large changes**: If changes touch multiple concerns, split them into separate commits
+- **Conventional commit format**: Use the format `<type>: <description>` where type is one of:
+  - `feat`: A new feature
+  - `fix`: A bug fix
+  - `docs`: Documentation changes
+  - `style`: Code style changes (formatting, etc)
+  - `refactor`: Code changes that neither fix bugs nor add features
+  - `perf`: Performance improvements
+  - `test`: Adding or fixing tests
+  - `chore`: Changes to the build process, tools, etc.
+- **Present tense, imperative mood**: Write commit messages as commands (e.g., "add feature" not "added feature")
+- **Concise first line**: Keep the first line under 72 characters
+  - `feat`: New feature
+  - `fix`: Bug fix
+  - `docs`: Documentation
+  - `style`: Formatting/style
+  - `refactor`: Code refactoring
+  - `perf`: Performance improvements
+  - `test`: Tests
+  - `chore`: Tooling, configuration
+  - `ci`: CI/CD improvements
+  - `revert`: Reverting changes
+  - `test`: Add a failing test
+  - `fix`: Fix compiler/linter warnings
+  - `fix`: Fix security issues
+  - `chore`: Add or update contributors
+  - `refactor`: Move or rename resources
+  - `refactor`: Make architectural changes
+  - `chore`: Merge branches
+  - `chore`: Add or update compiled files or packages
+  - `chore`: Add a dependency
+  - `chore`: Remove a dependency
+  - `chore`: Add or update seed files
+  - `chore`: Improve developer experience
+  - `feat`: Add or update code related to multithreading or concurrency
+  - `feat`: Improve SEO
+  - `feat`: Add or update types
+  - `feat`: Add or update text and literals
+  - `feat`: Internationalization and localization
+  - `feat`: Add or update business logic
+  - `feat`: Work on responsive design
+  - `feat`: Improve user experience / usability
+  - `fix`: Simple fix for a non-critical issue
+  - `fix`: Catch errors
+  - `fix`: Update code due to external API changes
+  - `fix`: Remove code or files
+  - `style`: Improve structure/format of the code
+  - `fix`: Critical hotfix
+  - `chore`: Begin a project
+  - `chore`: Release/Version tags
+  - `wip`: Work in progress
+  - `fix`: Fix CI build
+  - `chore`: Pin dependencies to specific versions
+  - `ci`: Add or update CI build system
+  - `feat`: Add or update analytics or tracking code
+  - `fix`: Fix typos
+  - `revert`: Revert changes
+  - `chore`: Add or update license
+  - `feat`: Introduce breaking changes
+  - `assets`: Add or update assets
+  - `feat`: Improve accessibility
+  - `docs`: Add or update comments in source code
+  - `db`: Perform database related changes
+  - `feat`: Add or update logs
+  - `fix`: Remove logs
+  - `test`: Mock things
+  - `feat`: Add or update an easter egg
+  - `chore`: Add or update .gitignore file
+  - `test`: Add or update snapshots
+  - `experiment`: Perform experiments
+  - `feat`: Add, update, or remove feature flags
+  - `ui`: Add or update animations and transitions
+  - `refactor`: Remove dead code
+  - `feat`: Add or update code related to validation
+  - `feat`: Improve offline support
+
+## Guidelines for Splitting Commits
+
+When analyzing the diff, consider splitting commits based on these criteria:
+
+1. **Different concerns**: Changes to unrelated parts of the codebase
+2. **Different types of changes**: Mixing features, fixes, refactoring, etc.
+3. **File patterns**: Changes to different types of files (e.g., source code vs documentation)
+4. **Logical grouping**: Changes that would be easier to understand or review separately
+5. **Size**: Very large changes that would be clearer if broken down
+
+## Examples
+
+Good commit messages:
+- feat: add user authentication system
+- fix: resolve memory leak in rendering process
+- docs: update API documentation with new endpoints
+- refactor: simplify error handling logic in parser
+- fix: resolve linter warnings in component files
+- chore: improve developer tooling setup process
+- feat: implement business logic for transaction validation
+- fix: address minor styling inconsistency in header
+- fix: patch critical security vulnerability in auth flow
+- style: reorganize component structure for better readability
+- fix: remove deprecated legacy code
+- feat: add input validation for user registration form
+- fix: resolve failing CI pipeline tests
+- feat: implement analytics tracking for user engagement
+- fix: strengthen authentication password requirements
+- feat: improve form accessibility for screen readers
+
+Example of splitting commits:
+- First commit: feat: add new solc version type definitions
+- Second commit: docs: update documentation for new solc versions
+- Third commit: chore: update package.json dependencies
+- Fourth commit: feat: add type definitions for new API endpoints
+- Fifth commit: feat: improve concurrency handling in worker threads
+- Sixth commit: fix: resolve linting issues in new code
+- Seventh commit: test: add unit tests for new solc version features
+- Eighth commit: fix: update dependencies with security vulnerabilities
+
+## Command Options
+
+- `--no-verify`: Skip running the pre-commit checks (lint, build, generate:docs)
+
+## Important Notes
+
+- By default, pre-commit checks (`yarn lint`) will run to ensure code quality
+- If these checks fail, you'll be asked if you want to proceed with the commit anyway or fix the issues first
+- If specific files are already staged, the command will only commit those files
+- If no files are staged, it will automatically stage all modified and new files
+- The commit message will be constructed based on the changes detected
+- Before committing, the command will review the diff to identify if multiple commits would be more appropriate
+- If suggesting multiple commits, it will help you stage and commit the changes separately
+- Always reviews the commit diff to ensure the message matches the changes

.gitignore

@@ -77,3 +77,4 @@ test-report.html
 
 # Ignore tamagui config file 
 .tamagui
+scripts/nitro-view/template/android/.gradle

example/react-native/pages/DeviceUtilsTestPage.tsx

@@ -115,7 +115,7 @@ export function DeviceUtilsTestPage({ onGoHome, safeAreaInsets }: DeviceUtilsTes
     clearResults();
     try {
       if (!spanningCallbackActive) {
-        deviceUtils.onSpanningChanged((spanning: boolean) => {
+        deviceUtils.addSpanningChangedListener((spanning: boolean) => {
           setIsSpanning(spanning);
           setResult({ 
             spanningCallbackTriggered: true, 

native-modules/react-native-background-thread/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-background-thread",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-background-thread",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-check-biometric-auth-changed/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-check-biometric-auth-changed",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-check-biometric-auth-changed",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-cloud-kit-module/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-cloud-kit-module",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-cloud-kit-module",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-device-utils/android/src/main/java/com/margelo/nitro/reactnativedeviceutils/ReactNativeDeviceUtils.kt

@@ -9,12 +9,14 @@ import androidx.core.util.Consumer
 import androidx.window.layout.FoldingFeature
 import androidx.window.layout.WindowInfoTracker
 import androidx.window.layout.WindowLayoutInfo
+import androidx.window.java.layout.WindowInfoTrackerCallbackAdapter
 import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.LifecycleEventListener
 import com.facebook.react.bridge.ReactApplicationContext
 import com.margelo.nitro.NitroModules
 import com.margelo.nitro.core.Promise
 import java.util.concurrent.Executor
+import java.util.concurrent.CopyOnWriteArrayList
 
 data class Listener(
   val id: Double,
@@ -28,24 +30,15 @@ class ReactNativeDeviceUtils : HybridReactNativeDeviceUtilsSpec(), LifecycleEven
   private var isSpanning = false
   private var layoutInfoConsumer: Consumer<WindowLayoutInfo>? = null
   private var windowInfoTracker: WindowInfoTracker? = null
-  private var spanningChangedListeners: MutableList<Listener> = mutableListOf()
+  private var callbackAdapter: WindowInfoTrackerCallbackAdapter? = null
+  private var spanningChangedListeners: MutableList<Listener> = CopyOnWriteArrayList()
   private var isObservingLayoutChanges = false
   private var nextListenerId = 0.0
   private var isDualScreenDeviceDetected: Boolean? = null
 
-  companion object {
-    private var reactContext: ReactApplicationContext? = null
-
-    fun setReactContext(context: ReactApplicationContext) {
-      reactContext = context
-    }
-   }
-
   init {
       NitroModules.applicationContext?.let { ctx ->
           ctx.addLifecycleEventListener(this)
-      } ?: run {
-
       }
   }
 
@@ -241,12 +234,12 @@ class ReactNativeDeviceUtils : HybridReactNativeDeviceUtilsSpec(), LifecycleEven
     }
   }
 
-  override fun addSpanningChangedListener(callback: (isSpanning: Boolean) -> Unit): Double {
-    var id = nextListenerId
+  override fun addSpanningChangedListener(callback: (isSpanning: Boolean) -> Unit): Double = synchronized(this) {
+    val id = nextListenerId
     nextListenerId++
     val listener = Listener(id, callback)
     spanningChangedListeners.add(listener)
-    return id
+    return@synchronized id
   }
 
     override fun removeSpanningChangedListener(id: Double) {
@@ -272,11 +265,14 @@ class ReactNativeDeviceUtils : HybridReactNativeDeviceUtilsSpec(), LifecycleEven
 
         // Use main executor for callbacks
         val mainExecutor: Executor = ContextCompat.getMainExecutor(activity)
-        
+
         // Subscribe to window layout changes using the Java adapter
-        val callbackAdapter = androidx.window.java.layout.WindowInfoTrackerCallbackAdapter(windowInfoTracker!!)
+        callbackAdapter = WindowInfoTrackerCallbackAdapter(windowInfoTracker!!)
 
-        callbackAdapter.addWindowLayoutInfoListener(
+        if (callbackAdapter == null) {
+          return
+        }
+        callbackAdapter!!.addWindowLayoutInfoListener(
           activity,
           mainExecutor,
           layoutInfoConsumer!!
@@ -292,14 +288,18 @@ class ReactNativeDeviceUtils : HybridReactNativeDeviceUtilsSpec(), LifecycleEven
       return
     }
     isObservingLayoutChanges = false
-    if (windowInfoTracker != null && layoutInfoConsumer != null) {
-      try {
-        // The listener will be cleaned up when the activity is destroyed
-        layoutInfoConsumer = null
-        windowInfoTracker = null
-      } catch (e: Exception) {
-        // Ignore cleanup errors
+
+    // Properly clean up window layout listener
+    try {
+      if (callbackAdapter != null && layoutInfoConsumer != null) {
+        callbackAdapter!!.removeWindowLayoutInfoListener(layoutInfoConsumer!!)
       }
+    } catch (e: Exception) {
+      // Ignore cleanup errors
+    } finally {
+      callbackAdapter = null
+      layoutInfoConsumer = null
+      windowInfoTracker = null
     }
   }
 
@@ -321,8 +321,14 @@ class ReactNativeDeviceUtils : HybridReactNativeDeviceUtilsSpec(), LifecycleEven
     val activity = getCurrentActivity() ?: return
     activity.runOnUiThread {
       try {
+        // Clamp color values to valid range [0, 255]
+        val red = Math.max(0, Math.min(255, r.toInt()))
+        val green = Math.max(0, Math.min(255, g.toInt()))
+        val blue = Math.max(0, Math.min(255, b.toInt()))
+        val alpha = Math.max(0, Math.min(255, a.toInt()))
+
         val rootView = activity.window.decorView
-        rootView.rootView.setBackgroundColor(Color.rgb(r.toInt(), g.toInt(), b.toInt()))
+        rootView.rootView.setBackgroundColor(Color.argb(alpha, red, green, blue))
       } catch (e: Exception) {
         e.printStackTrace()
       }

native-modules/react-native-device-utils/android/src/main/java/com/margelo/nitro/reactnativedeviceutils/ReactNativeDeviceUtilsPackage.kt

@@ -8,7 +8,6 @@ import com.facebook.react.module.model.ReactModuleInfoProvider
 class ReactNativeDeviceUtilsPackage : BaseReactPackage() {
     override fun getModule(name: String, reactContext: ReactApplicationContext): NativeModule? {
         // Set the React context for the DeviceUtils module
-        ReactNativeDeviceUtils.setReactContext(reactContext)
         return null
     }
 

native-modules/react-native-device-utils/ios/ReactNativeDeviceUtils.swift

@@ -33,9 +33,19 @@ class ReactNativeDeviceUtils: HybridReactNativeDeviceUtilsSpec {
 
     public func changeBackgroundColor(r: Double, g: Double, b: Double, a: Double) throws -> Void {
         DispatchQueue.main.async {
-            let color = UIColor(red: r/255, green: g/255, blue: b/255, alpha: a/255)
-            let rootViewController = UIApplication.shared.delegate?.window??.rootViewController
-            rootViewController?.view.backgroundColor = color
+            // Clamp color values to valid range [0, 255]
+            let red = max(0, min(255, r))
+            let green = max(0, min(255, g))
+            let blue = max(0, min(255, b))
+            let alpha = max(0, min(255, a))
+
+            let color = UIColor(red: red/255.0, green: green/255.0, blue: blue/255.0, alpha: alpha/255.0)
+
+            // Fix optional chaining syntax
+            if let window = UIApplication.shared.delegate?.window,
+               let rootViewController = window?.rootViewController {
+                rootViewController.view.backgroundColor = color
+            }
         }
     }
 }

native-modules/react-native-device-utils/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-device-utils",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-device-utils",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-get-random-values/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-get-random-values",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-get-random-values",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-keychain-module/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-keychain-module",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "react-native-keychain-module",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",

native-modules/react-native-lite-card/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onekeyfe/react-native-lite-card",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "lite card",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",