Repository navigation
feat: expose SNI file upload progress - #265
Draft
huhuanming wants to merge 2 commits into
Draft
huhuanming wants to merge 2 commits into
huhuanming wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Log uploads had no interim progress while the existing
uploadFile(config)Promise was pending.What changed
getUploadProgress(requestId): Promise<{ bytesSent, totalBytes } | null>to the matching JS and native module. It returnsnullwhen that module has no active snapshot for the ID. The existinguploadFilearguments, response, timeout, security, and fallback behavior remain unchanged.Validation
no-voidwarnings.git diff --checkpassed.Coordinated release
Ship this native module change together with OneKeyHQ/app-monorepo#14532. The JS and native progress methods must be present in the same app release. Native package publication, the app's package version pin update, and an app rebuild are required rollout steps; this PR does not publish or bump a version.