Repository navigation
fix: retain overlay windows during child navigation transitions - #264
huhuanming wants to merge 1 commit into
Conversation
|
@codex review |
|
@codex security review |
|
Cursor review failed. Remote error: |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
背景
跟进已合并的 #263 中的 两条 P2 review 意见。原修复覆盖了 More 浮窗退出时,主窗口上账户选择器交互转场的窗口生命周期;后续审查指出
interactiveCoordinator(in:)只查看根控制器及presentedViewController链。UIKit 文档说明,transitionCoordinator会向父控制器回退,但根控制器不会因此自动看到其子控制器的交互转场。已挂载的子UINavigationController若正在交互式 pop,旧实现可能提前释放退出浮窗的 window context。另一个意见涉及 NativeList 视频首帧测试:若中间的
XCTUnwrap提前抛错,末尾的recycle()不会执行。现有容器移除和对象析构仍有取消路径;本 PR 将测试中的显式清理改为defer,保证各退出路径一致,不将其描述为已证实的生产资源泄漏。改动
defer recycle();保留测试缓存复用所需的中途recycle()以及全部原断言和等待期限。验证
UINavigationController,启动百分比驱动的交互式 pop;确认交互仅出现在 child,旧版恰在“退出窗口应保留”的断言失败。git diff --check通过。本 PR 的 hosted CI 已全部通过,包括ios-native、ios-xctest和device-utils-store;视频首帧用例实际通过(3.445 秒),NativeList XCTest 套件为 95 项、1 项既有跳过、0 失败。此前 fix: retain iOS overlay window during interactive dismissal #263 的 hosted CI 和录屏不作为本 PR 新增 child 路径的验证证据。#263 的修复前后录屏记录的是账户选择器主窗口交接,并非本 PR 新增的子导航路径。这里的真实 UIKit 验证仍限模拟器;真机和更广的应用场景尚未验证。本 PR 不发布 SDK,也不合并应用侧更改。
独立复核已核对本次源码、真实 UIKit 红/绿结果及线上差异。Devin 的检查状态为通过,但其完整审查因额度不足而跳过,不计作额外审查证据。