Jaden: fix config.name bug and inline styles in PR Grading Test (DONE Jaden) - #5468
Open
Jaden300 wants to merge 1 commit into
Open
Jaden: fix config.name bug and inline styles in PR Grading Test (DONE Jaden)#5468Jaden300 wants to merge 1 commit into
Jaden300 wants to merge 1 commit into
Conversation
…ask #1334 - Move inline styles from PRGradingTest.jsx to CSS module (deleteButton, container, subtitle classes) - Fix config.teamName -> config.name in index.jsx; team objects use 'name' not 'teamName' causing PRGradingScreen to receive undefined team name when navigating from a DB config
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Jaden300
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jaden: fix config.name bug and inline styles in PR Grading Test (DONE Jaden)- #5468
Description
Implements Task #1334 - PR Review Team Analytics Dashboard: PR Grading Screen fixes.
Main changes explained
config.teamName->config.nameinPRGradingScreen/index.jsx: team objects usename(notteamName), so navigating to a DB-backed config was passingundefinedas the team name toPRGradingScreenPRGradingTest.jsxintoPRGradingTest.module.css: delete button positioning/color, container padding, and subtitle colorRelated PRs
How to test
Jaden_Task1334_PRGrading_ConfigCreation_PageNotFoundnpm run build && npm run startnpm install && npm run start:local/pr-grading-test