Jaden: fix dark mode implementation for PR Dashboard (DONE Jaden) - #5467
Open
Jaden300 wants to merge 1 commit into
Open
Jaden: fix dark mode implementation for PR Dashboard (DONE Jaden)#5467Jaden300 wants to merge 1 commit into
Jaden300 wants to merge 1 commit into
Conversation
- Fix PRReviewTeamAnalytics mapStateToProps to extract only darkMode instead of passing entire Redux state as prop - Replace all inline style dark mode overrides in PRReviewTeamAnalytics and DurationFilter with CSS module .dark class toggles - Add .dark variant classes to PRReviewTeamAnalytics.module.css and DurationFilter.module.css for all hardcoded light-mode colors - Keep Recharts SVG fill/stroke as JS values - CSS cannot target SVG attributes rendered by Recharts - Remove leftover debug console.log statements from Header.jsx resize handler that were not cleaned up in PR #5120
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Jaden300
changed the title
Jaden300
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jaden: fix dark mode implementation for PR Dashboard (DONE Jaden)- #5467
Description
Follow-up fixes for PR #5120 - Task #1333 (Priority High)
Fixes incorrect dark mode implementation across the PR Dashboard pages introduced in #5120.
Related PRs
Main changes
PRReviewTeamAnalytics.jsxmapStateToProps: was passing entire Redux state as a prop (state => ({ state })); now correctly extracts onlydarkMode: state.theme.darkMode.darkclass toggling (consistent with the rest of the codebase)fill/strokeremain as JS values - CSS cannot target SVG attributes rendered by RechartsPRReviewTeamAnalytics.module.css.darkvariant classes for container, title, labels, tooltip, insights panel, loading/error/empty states, and spinnerDurationFilter.jsxstyleprops (color,backgroundColor,borderColor)styles.darkCSS module class toggled by thedarkModepropDurationFilter.module.css.darkvariant classes for label, select input, and dropdown iconHeader.jsxconsole.logstatements from the resize event handler that were not cleaned up in Sayali: add consolidated PR Dashboard dropdown to header for Task #39 #5120How to test
Jaden_Task1333_PRDashboard_DarkModeFixnpm install && npm run start:localvod.mov