Mahathi - Improve applicant volunteer ratio chart visualization - #5457
Open
mahathiganimi wants to merge 1 commit into
Open
Mahathi - Improve applicant volunteer ratio chart visualization#5457mahathiganimi wants to merge 1 commit into
mahathiganimi wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
iAbhi001
self-requested a review
August 23, 2026 03:07
iAbhi001
requested changes
Aug 23, 2026
iAbhi001
left a comment
There was a problem hiding this comment.
Pull Request Review Feedback
Hi @mahathiganimi,
Thanks for working on the UI improvements for the applicant-to-volunteer ratio visualization.
During local testing on this branch, I encountered a blocking error where the role options fail to populate.
Issue Identified
- Behavior: When navigating to
/applicant-volunteer-ratio, the UI displays a "Failed to load roles" error message, preventing the role filter from populating and blocking the chart from rendering. - Network / Console Observations:
- Endpoint fetching roles fails to resolve / returns an error state.
- (Optional: Add specific HTTP status code or console error here, e.g.,
500 Internal Server Error on GET /api/...)
Steps to Reproduce
- Check out branch
Mahathi_improve_applicant_volunteer_ratio_chart_uilocally (or test against the latest backend dependency). - Log in as an Admin user.
- Clear site data/cache and navigate to
http://localhost:5173/applicant-volunteer-ratio. - Observe the "Failed to load roles" error state.
Requested Actions
- Please verify if there is an unhandled edge case or missing fallback when fetching role data.
- If this requires specific seed data or additional updates from backend PR [#2313](OneCommunityGlobal/HGNRest#2313), please update the testing instructions or handle the error gracefully so the UI doesn't break.
Once this is resolved, I’ll be happy to re-test and complete the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Issue found:
Related PRS (if any):
This frontend PR is related to the https://github.com/OneCommunityGlobal/HGNRest/pull/2313 backend PR.
Old PR https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/5123
Changes
Role.Number of Applications and Hires.All Rolesoption to the Role filter.Testing
Chart loads correctly and does not get stuck on "Loading..."
Legend colors should match chart bars (blue for Total Applications, green for People Hired)
Legend should be clearly visible and readable
Note
This PR specifically addresses post-merge feedback related to chart loading