sireesha fix trim input prevent empty table#5370
Open
kunchalasireesha wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
added
the
High Priority - Please Review First
kunchalasireesha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was opened to remove trailing spaces from the search input text to ensure the badge table is filtered correctly.
Related PRS (if any):
This is a redo of this PR: #4151
Main changes explained:
The AssignBadgePopup.jsx component has been modified to fix the bug.
How to test:
check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
Log in as an admin or owner user
go to view profile → Assign Badges
Type the full name of a badge and add a space, then check if the table still shows the badge correctly.
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.