Abhishek_fix: add missing dark mode styles for pie chart legend table text#5366
Abhishek_fix: add missing dark mode styles for pie chart legend table text#5366Abhi-R0211 wants to merge 2 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @one-community, opened this PR to address the dark mode text contrast issue on the People Report "Tasks With Completed Hours" table (flagged in the Reports UI issues task, related to #4283 and #5015). Could you assign a reviewer or take a look when you get a chance? Let me know if any additional context is needed. |
kzou55
left a comment
There was a problem hiding this comment.
|
|
Hi @kzou55, thank you for the review! To clarify scope: this PR was originally opened to fix a dark mode text contrast issue specifically in the "Tasks With Completed Hours" table (task name and hours text were unreadable against the dark background due to a missing CSS class). That's the fix described in the PR description and covered by the listed test steps. The header contrast issue you flagged on "Time Logged to Projects/Non-tasks" is technically a separate element outside that original scope, but since it's the same root cause (a missing dark mode text color rule) in the same component, I've gone ahead and included the fix here rather than opening a new task for it. Issues addressed:
Please re-review when you get a chance. Let me know if anything else needs attention! |










Related PRs:
Main changes explained
The "Tasks With Completed Hours" table (Dashboard → Reports → People → select person) references a
pie-chart-legend-table-darkCSS class inPieChart.jsxfor dark mode styling, but this class was never actually defined inPieChart.module.css— only referenced once inside an unrelated hover selector. As a result, task name and hours text in the table body had no explicit dark-mode color and inherited a hardcoded semi-transparent black (rgb(0 0% 50%)) from a parent wrapper, rendering nearly invisible against the dark background.Added the missing
.pie-chart-legend-table-darkstyles (header background, header text color, cell text color) inPieChart.module.css. Light mode styling and all other functionality are untouched — this component (src/components/common/PieChart) is only used by the People report, so the change has no impact on other pages.Files changed:
src/components/common/PieChart/PieChart.module.cssHow to test
Abhishek_Fix_PeopleTasksPieChart_DarkModeScreenshots or videos of changes