Sphurthy-added dark mode#5357
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
- UsageRecord Record popup doesn't show any content and the alignment of Usage record, updates and purchases need improvement as it looks compressed. View Update history is not clickable. Please scroll down and look for other comments along with screenshots.
- Text contrast improvement needed in purchase request submission popup.
- Project dropdown background is white in dark mode, and on hover highlight is contrast need improvement.
-Image uploaded shows enlarged
|
DeepighaJ
left a comment
There was a problem hiding this comment.
- Tested the PR locally.
- The Usage Record issue is fixed, it displays the content now.
- The hover issue is fixed in material/update.
- The image upload issue is fixed in material/add.
Issue: - The Request Submitted successfully title color can be improved since its in black its blending with grey background in dark mode.
- The View Update, Add material, View Update history buttons under /bmdashboard/materials are still not clickable. Is it future scope?
- The update, usage, purchase view icons alignment still exist. Is it covered under this scope?
There was a problem hiding this comment.
Hi Sphurthy,
I ran and tested the PR locally.
Verified the following pages are fine
-
bmdashboard/materials/purchase
-
bmdashboard/materials/addpage
-
bmdashboard/reusables/purchase
-
bmdashboard/tools
-
bmdashboard/tools/purchase
-
bmdashboard/tools/add
-
bmdashboard/tools/log
-
bmdashboard/tools/equpimentupdate
Issues/Concerns
/bmdashboardhas a random layer above the section
-
The Date picker component has overlapping issues and not fully in dark mode in these pages materials, reusables, consumables, issue
-
The update form/popup Title needs better contrast
-
Many of the /Update pages like in /materials, /reusables have issues
-
Datepicker icon could have better contrast. And the datepicker dropdown isn't in Dark Mode
-
Project filter isn't in Dark Mode. And it's dropdown has poor contrast.
-
Hovering over the row data has poor contrast
-
bmdashboard/projects/:projectid` - Member working today section not in dark mode

-
bmdashboard/eequipment/:equipmentID- page not fully in dark mode

- Some buttons were not responsive but given this is just a dark mode PR, I'm assuming those issues are out of scope. Let me know if that's correct. Ex. Add Material, Edit Name/Measurement, View Update History"













Description
Related PRS (if any):
None
Main changes explained:
How to test:
Screenshots or videos of changes: