Fixed 4 critical UI/UX issues in the Email Management system: - #4726
Closed
apoorvajainrp21 wants to merge 1 commit into
Closed
Fixed 4 critical UI/UX issues in the Email Management system:#4726apoorvajainrp21 wants to merge 1 commit into
apoorvajainrp21 wants to merge 1 commit into
Conversation
…fline alerts, and preview images - Add VIDEO variable type support with video icon in EmailTemplateEditor - Fix Clear Draft to properly reset form state in IntegratedEmailSender - Fix offline alert banner to auto-dismiss when connection restored - Fix preview images to display properly with constrained sizing in CSS - Add automatic HTML wrapping for image/video variables in preview utils
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
iAbhi001
self-requested a review
August 4, 2026 22:27
iAbhi001
requested changes
Aug 4, 2026
iAbhi001
left a comment
There was a problem hiding this comment.
Hi @apoorvajainrp21, thanks for working on these fixes!
I attempted to test this locally on the PR branch, but I am getting Page Not Found (404) when navigating to the testing routes listed in the description (/announcements/email/templates and /announcements/email/sender).
Before we can complete the functional review and testing, please address the following:
🚨 Action Items Required
-
Route Guidance / Navigation:
- Could you clarify the exact updated URL routes or navigation steps to access the Email Template Editor and Email Sender pages locally?
-
Merge Conflicts:
- There are active merge conflicts with
developmentacross all 4 files (IntegratedEmailSender.jsx,IntegratedEmailSender.module.css,utils.js,EmailTemplateEditor.jsx). - Please rebase/merge
developmentintopr-4492-finaland resolve the conflict markers.
- There are active merge conflicts with
-
SonarCloud Security Hotspots:
- The SonarCloud Quality Gate is currently failing due to 3 Security Hotspots. Please review the SonarQube analysis and address those security flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fixed 4 critical UI/UX issues in the Email Management system:
Files Changed
IntegratedEmailSender.jsx- Added handleClearDraft and offline alert auto-dismissIntegratedEmailSender.module.css- Added image size constraints for previewEmailTemplateEditor.jsx- Added VIDEO type support with iconutils.js- Added automatic HTML wrapping for images/videosTesting
Test #1 - VIDEO Badge Type
/announcements/email/templatesTest #2 - Clear Draft Functionality
/announcements/email/sender(or/sendemail)Test #3 - Offline Alert Auto-Dismiss
Test #4 - Preview Image Sizing
https://picsum.photos/2000/2000)Test #5 - Auto HTML Wrapping (BONUS)
https://www.youtube.com/watch?v=dQw4w9WgXcQ)Related PRs