Skip to content

Yuheard test CI fail fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CjLogic merged 1 commit into from
Aug 29, 2026
Merged

Yuheard test CI fail fix #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/pty-service.yuheard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@
}))

vi.mock('node-pty', () => ({ spawn: mocks.spawn }))
vi.mock('fs', async (importOriginal) => {
const actual = await importOriginal<typeof import('fs')>()
return {
...actual,
// GitHub runners do not install Fish. Keep shell discovery out of this
// file: pretend the first POSIX candidate exists so spawn stays Fish.
existsSync: (p: Parameters<typeof actual.existsSync>[0]) =>
String(p) === '/usr/bin/fish' || actual.existsSync(p),
}
})
vi.mock('./yuheard-wrapper', () => ({
bashKeepWrapPrompt: vi.fn((dir: string) => `PATH=${dir}:$PATH`),
codexNotifyArgv: vi.fn(() => ['-c', 'notify=[]']),
Expand Down Expand Up @@ -66,7 +76,7 @@
})

expect(result.ok).toBe(true)
expect(notePaneSpawned).toHaveBeenCalledWith('pane-1', '/tmp')

Check failure on line 79 in src/main/pty-service.yuheard.test.ts

View workflow job for this annotation

GitHub Actions / verify (windows-latest)

src/main/pty-service.yuheard.test.ts > PtyService YuHeard bundle boundary > uses injected server access and statically imported wrappers for a Fish shell 

AssertionError: expected "vi.fn()" to be called with arguments: [ 'pane-1', '/tmp' ]

Received:

  1st vi.fn() call:

  [
    "pane-1",
-   "/tmp",
+   "C:\\Users\\runneradmin",
  ]


Number of calls: 1

 ❯ src/main/pty-service.yuheard.test.ts:79:29
expect(mocks.installWrapper).toHaveBeenCalledWith(
'pane-1',
['codex', 'claude'],
Expand Down
Loading