Update dependencies in pyproject.toml and setup.py#232
Open
stephen-huan wants to merge 3 commits intoOfflineIMAP:masterfrom
Open
Update dependencies in pyproject.toml and setup.py#232stephen-huan wants to merge 3 commits intoOfflineIMAP:masterfrom
stephen-huan wants to merge 3 commits intoOfflineIMAP:masterfrom
Conversation
13 tasks
thekix
approved these changes
Jan 28, 2026
There was a problem hiding this comment.
Pull request overview
This PR reorganizes dependencies to better reflect their actual usage patterns. urllib3 is moved from core dependencies to the testinternet optional dependency group since it's only used in test/contrib code, and PySocks is added as a new optional dependency for proxy support.
Changes:
- Moved urllib3 from main dependencies to testinternet optional dependencies
- Added PySocks as a new optional dependency for proxy support
- Changed keyring[keyring] to keyring in setup.py for consistency
- Alphabetically sorted optional dependencies in both pyproject.toml and setup.py
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Removed urllib3 from install_requires, updated extras_require to add pysocks and move urllib3 to testinternet, changed keyring[keyring] to keyring, alphabetized extras |
| pyproject.toml | Removed urllib3 from dependencies, added pysocks to optional-dependencies, moved urllib3 to testinternet optional-dependencies, alphabetized optional-dependencies |
| requirements-testinternet.txt | Added urllib3~=1.25.9 to match the new testinternet optional dependency |
| requirements-pysocks.txt | New file containing pysocks dependency for the new pysocks optional dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It appears urllib3 is only used in contrib/internet-urllib3.py, so put it with certifi in the `testinternet` optional-dependencies group. Signed-off-by: Stephen Huan <stephen.huan@cgdct.moe>
PySocks is used for the optional proxy feature. Signed-off-by: Stephen Huan <stephen.huan@cgdct.moe>
For consistency with pyproject.toml and requirements-keyring.txt. Signed-off-by: Stephen Huan <stephen.huan@cgdct.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Move
urllib3fromdependenciestotestinterneturllib3is only used incontrib/internet-urllib3.py, so put it withcertifiin thetestinternetoptional-dependencies group.Add PySocks optional-dependencies
optional-dependencies.Change
keyring[keyring]->keyringinsetup.pypyproject.tomlandrequirements-keyring.txt.I've read the DCO.
I've read the Coding Guidelines
The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
Code changes follow the style of the files they change.
Code is tested (provide details).
References
Additional information