This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Please add Exchange2013 to the enum#547
Open
yiyangli-okta wants to merge 1 commit intoOfficeDev:masterfrom
Open
Please add Exchange2013 to the enum#547yiyangli-okta wants to merge 1 commit intoOfficeDev:masterfrom
yiyangli-okta wants to merge 1 commit intoOfficeDev:masterfrom
Conversation
Hi, there, this is Yiyang Li, from Okta. I am forking the project because I need to implement InstallAppRequest and InstallAppResponse by copying codes from EWS Managed API. Since the minimum version of InstallApp is 2013, could you please add this enum? Thanks. Yiyang Li
Current coverage is 10.43% (diff: 100%)
|
Member
|
once there is specific code integrated that will make use of the "new version" we should add more exchange versions to the enum but until that time I do not see a specific need for it since it does not provide further features?! |
Author
|
hi, @serious6, could you take a look at this PR? is this one of the specific needs? I really like the InstallAppRequest, it helps our company to integrate office 365 suite with other 3rd party better -- so that users don't need to enable apps in app store. Could you review the PR when you have time? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, there, this is Yiyang Li, from Okta. I am forking the project because I need to implement InstallAppRequest and InstallAppResponse by copying codes from EWS Managed API. Since the minimum version of InstallApp is 2013, could you please add this enum?
Thanks.
Yiyang Li