This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Issue #425: Fix hanging StreamingSubscriptionConnection.close()#496
Open
dconnelly wants to merge 2 commits intoOfficeDev:masterfrom
Open
Issue #425: Fix hanging StreamingSubscriptionConnection.close()#496dconnelly wants to merge 2 commits intoOfficeDev:masterfrom
dconnelly wants to merge 2 commits intoOfficeDev:masterfrom
Conversation
StreamingSubscriptionConnection.close() calls HttpWebRequest.close() which will first attempts to consume the response before releasing the connection. This unfortunately will hang since the notification reader thread is still blocked reading from the same connection. The fix is to just the connection without consuming the response entity.
Current coverage is
|
…already disconnecting
| } | ||
| } | ||
|
|
||
| private static boolean isSocketClosed(Throwable e) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamingSubscriptionConnection.close() calls HttpWebRequest.close() which first
attempts to consume the response before releasing the connection. This unfortunately
will hang since the notification reader thread is still blocked reading from the same
connection. The fix is to just the connection without consuming the response entity.