Skip to content

Add BurnMultiGas to Burner interface#4335

Merged
tsahee merged 1 commit intoNIT-4405-2from
gligneul/nit-4455
Feb 6, 2026
Merged

Add BurnMultiGas to Burner interface#4335
tsahee merged 1 commit intoNIT-4405-2from
gligneul/nit-4455

Conversation

@gligneul
Copy link
Copy Markdown
Contributor

@gligneul gligneul commented Feb 5, 2026

Close NIT-4455

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.31%. Comparing base (2844590) to head (a857b72).
⚠️ Report is 2 commits behind head on NIT-4405-2.

Additional details and impacted files
@@               Coverage Diff               @@
##           NIT-4405-2    #4335       +/-   ##
===============================================
- Coverage       57.27%   33.31%   -23.96%     
===============================================
  Files             483      483               
  Lines           57563    57569        +6     
===============================================
- Hits            32969    19180    -13789     
- Misses          19701    35051    +15350     
+ Partials         4893     3338     -1555     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
4138 6 4132 0
View the top 3 failed tests by shortest run time
TestMultigasStylus_StorageWrite/out_of_gas
Stack Traces | 0.020s run time
=== RUN   TestMultigasStylus_StorageWrite/out_of_gas
INFO [02-05|13:32:12.341] Log index head rendering in progress     firstblock=0 lastblock=1 processed=2 remaining=0 elapsed=1.348s
INFO [02-05|13:32:12.341] Log index head rendering finished        firstblock=0 lastblock=1 processed=2 elapsed=1.348s
INFO [02-05|13:32:12.346] Submitted transaction                    hash=0x21156a26283e527a05183b527fe31796b9b9d1f6cd4ffa0bca28b5c5d72679ba from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=4 recipient=0x3a0a61C11D96F5B8c1492bEaA5bDAedefFff15E8 value=0
    multigas_stylus_program_test.go:380: 
        	Error Trace:	/home/runner/work/nitro/nitro/system_tests/multigas_stylus_program_test.go:380
        	Error:      	An error is expected but got nil.
        	Test:       	TestMultigasStylus_StorageWrite/out_of_gas
--- FAIL: TestMultigasStylus_StorageWrite/out_of_gas (0.02s)
TestMultigasStylus_StorageWrite
Stack Traces | 1.200s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-05|13:32:12.086] Blockchain stopped
INFO [02-05|13:32:12.086] Loaded most recent local block           number=0 hash=cdcf85..0b1500 age=56y10mo4w
INFO [02-05|13:32:12.086] Initialized transaction indexer          range="last 126230400 blocks"
INFO [02-05|13:32:12.086] Persisted dirty state to disk            size=8.67KiB  elapsed=1.554ms
INFO [02-05|13:32:12.087] Blockchain stopped
WARN [02-05|13:32:12.087] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [02-05|13:32:12.088] sequencer enabled without l1 client
WARN [02-05|13:32:12.088] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
INFO [02-05|13:32:12.088] State scheme set by user                 scheme=path
WARN [02-05|13:32:12.089] Getting file info                        dir= error="stat : no such file or directory"
INFO [02-05|13:32:12.091] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.6
WARN [02-05|13:32:12.091] P2P server will be useless, neither dialing nor listening
INFO [02-05|13:32:12.091] Submitted transaction                    hash=0xb1ca2e5ee56c3c6dc92302ef1fc98e055762211c77008e4fe86dd77131486cfe from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=3 recipient=0x0000000000000000000000000000000000000070 value=0
INFO [02-05|13:32:12.093] Log index head rendering in progress     firstblock=0 lastblock=1 processed=2 remaining=0 elapsed=1.402s
INFO [02-05|13:32:12.093] Log index head rendering finished        firstblock=0 lastblock=1 processed=2 elapsed=1.402s
INFO [02-05|13:32:12.360] Waiting background transaction indexer to exit
INFO [02-05|13:32:12.360] Persisting dirty state                   head=5 root=b56f1e..d9bbcb layers=5
INFO [02-05|13:32:12.361] Persisted dirty state to disk            size=22.37KiB elapsed="939.827µs"
INFO [02-05|13:32:12.362] Blockchain stopped
--- FAIL: TestMultigasStylus_StorageWrite (1.20s)
TestBlocksReExecutorCommitState
Stack Traces | 3.190s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[02-05|15:15:01.641] Served eth_getBlockByNumber              reqid=1164  duration="64.771µs"
DEBUG[02-05|15:15:01.640] Served eth_getBlockByNumber              reqid=313   duration="53.981µs"
TRACE[02-05|15:15:01.641] Handled RPC response                     reqid=6045  duration=982ns
DEBUG[02-05|15:15:01.641] Served eth_maxPriorityFeePerGas          reqid=664   duration="29.254µs"
TRACE[02-05|15:15:01.641] Handled RPC response                     reqid=664   duration=952ns
DEBUG[02-05|15:15:01.641] Served eth_getBlockByNumber              reqid=663   duration="144.981µs"
DEBUG[02-05|15:15:01.641] Served eth_getBlockByNumber              reqid=666   duration="74.88µs"
TRACE[02-05|15:15:01.641] Handled RPC response                     reqid=2699  duration="1.953µs"
INFO [02-05|15:15:01.641] Generated snapshot                       accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="484.26µs"
TRACE[02-05|15:15:01.640] Handled RPC response                     reqid=7888  duration="1.693µs"
DEBUG[02-05|15:15:01.641] Executing EVM call finished              runtime="153.056µs"
DEBUG[02-05|15:15:01.641] Served eth_call                          reqid=665   duration="191.217µs"
DEBUG[02-05|15:15:01.641] Pushed sync data from consensus to execution synced=true  maxMessageCount=183 updatedAt=2026-02-05T15:15:01+0000 hasProgressMap=false
DEBUG[02-05|15:15:01.642] Served eth_getBlockByNumber              reqid=12738 duration="70.171µs"
DEBUG[02-05|15:15:01.641] Created new diff layer                   id=1                  block=0   nodesize=4.25KiB  statesize=2.01KiB
TRACE[02-05|15:15:01.641] got new header from L1                   number=31  hash=4be7fd..58c5b6                   header="&{ParentHash:0x18be2abb2b4966876425c3e5d4cc415ced405a8a907956c041b8a4677e8ce298 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0x0000000000000000000000000000000000000000 Root:0xe94f593a368e8afd68fdc1f29533169c4573d746d9f49d1d01753f252f7b3030 TxHash:0x1ddae977a9042027d3c8ebcffc366bd809eb3fa8c77e45e6a6b74613c91d85f9 ReceiptHash:0x1c6ad92e0793ea2c559cef75fcea2d483d67cb1e18e3d21b6360f1a80040adf7 Bloom:[0 0 0 0 8 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 64 64 2 0 8 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 2 0 0 0 16 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 8 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 2 0 0 0 0 0 0 0 0 0 0 0 0 0 64 0 0 8 0 0 0 0 32 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 128 0 0 0 0 0 16 0 0 0 0 16 0 0 0 0 0 0 0 0 0 64 0 0 0 0 0 0 0 0 2 0 0 32 0 2 0 0 0 0 0 0 64 0] Difficulty:+0 Number:+31 GasLimit:15460769 GasUsed:180442 Time:1770304531 Extra:[216 131 1 16 8 132 103 101 116 104 136 103 111 49 46 50 53 46 54 133 108 105 110 117 120] MixDigest:0x1b2f6c973c36240d6ac63263cb51dbc497561ec20f8d2f2f11cb0fd66802b370 Nonce:[0 0 0 0 0 0 0 0] BaseFee:+2607827786 WithdrawalsHash:0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421 BlobGasUsed:0xc018b860c8 ExcessBlobGas:0xc018b86120 ParentBeaconRoot:0x0000000000000000000000000000000000000000000000000000000000000000 RequestsHash:0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855}"
DEBUG[02-05|15:15:01.641] Served eth_blockNumber                   reqid=6046  duration="18.013µs"
DEBUG[02-05|15:15:01.640] Executing EVM call finished              runtime="880.206µs"
DEBUG[02-05|15:15:01.642] Served eth_call                          reqid=27116 duration=3.070154ms
--- FAIL: TestBlocksReExecutorCommitState (3.19s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@gligneul gligneul assigned tsahee and unassigned KolbyML Feb 5, 2026
Copy link
Copy Markdown
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

Copy link
Copy Markdown
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 1a2b1a3 into NIT-4405-2 Feb 6, 2026
33 of 34 checks passed
@tsahee tsahee deleted the gligneul/nit-4455 branch February 6, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants