Change to querybuilder interface#205
Open
cgsmith wants to merge 30 commits intoOXID-eSales:b-6.3.xfrom
Open
Conversation
Contributor
Author
|
Added DatabaseProvider back in per @mariolorenz email about OXID 6.1 compatibility. Just a note. I tried to get the GitHub workflows fixed but had issues and am not sure why. The PHPCS, PHPMD, and phpstan all work locally for me but for some reason fail on the workflows. I also split out the phpcs, phpmd, and phpstan actions in separate yaml files. |
# Conflicts: # src/Core/Logger.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a couple other issues which are corrected in this PR.
- Removed calls to deprecated DatabaseProvider and replaced with QueryBuilderInterface