ux: soften imperative language in fix commands section header#698
Open
Demiserular wants to merge 2 commits into
Open
ux: soften imperative language in fix commands section header#698Demiserular wants to merge 2 commits into
Demiserular wants to merge 2 commits into
Conversation
Replace 'Copy And Run These Fix Commands' with 'Suggested Fix Commands' to present information rather than instruct the user. Fixes OWASP#677
Author
|
@sonukapoor I think we need to change the |
Collaborator
That is correct. The tests are failing. |
Author
should I make the change ? |
Collaborator
|
@Demiserular Yes. Please see our contribution guidelines. https://github.com/OWASP/cve-lite-cli/blob/main/CONTRIBUTING.md#getting-started
|
Author
|
@sonukapoor kindly check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 'Copy And Run These Fix Commands' with 'Suggested Fix Commands' to present information rather than instruct the user.
Fixes #677
Summary
Softens the imperative language in the fix commands section header from "Copy And Run These Fix Commands" to "Suggested Fix Commands" to present information neutrally rather than instructing the user.
Why this change
The original phrasing "Copy And Run These Fix Commands" uses imperative language that reads as a command directed at the user, which was flagged as jarring. The tool should present information rather than instruct.
What changed
Validation
This is a text-only change with no functional impact. The change was verified by checking both occurrences in src/output/printers.ts were updated correctly.
User-facing impact
Does this change: