fix: return 400 when text_search is called without a text parameter - #802
Open
xovishnukosuri wants to merge 1 commit into
Open
xovishnukosuri wants to merge 1 commit into
xovishnukosuri wants to merge 1 commit into
Conversation
Calling /rest/v1/text_search without the text query parameter passed None to db.text_search(), which then called re.search() with None and raised a TypeError, resulting in a 500 instead of a descriptive 400. Added a guard in the endpoint and a regression test covering both the missing-parameter and empty-string cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /rest/v1/text_searchwithout thetextquery parameter passesNoneto
db.text_search(). Inside that function,re.search(pattern, None, ...)raises
TypeError, which Flask surfaces as a 500 Internal Server Error insteadof a client-side 400.
Reproduce:
Fix
Added a guard immediately after reading the
textparameter inapplication/web/web_main.py. Iftextis absent or empty, the endpointnow aborts with 400 before touching the database.
Test
Added
test_text_search_missing_paraminapplication/tests/web_main_test.pycovering:
textparameter → 400text=(empty string) → 400