Rework OWASP mapping importers as shared eval fixtures - #1098
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Summary by CodeRabbit
WalkthroughThe change adds shared OWASP mapping fixture utilities and a common parser base. OWASP parser classes now declare fixture names instead of duplicating JSON loading and CRE-linking logic. Tests cover fixture APIs and fallback resolution. CLI descriptions and fixture paths are updated. ChangesOWASP mapping parser consolidation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to No merge-blocking behavior issue was identified in the fixture-parser consolidation. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
application.utils.mapping_fixtures(list/load/load_all).OwaspMappingFixtureParserso they are no longer production catalog sources.import-all.Follow-up: rebase #1088 so B2 scoring loads this same gold (force-push after this lands).
Test plan
python -m unittest application.tests.owasp_mapping_fixtures_test application.tests.owasp_aisvs_parser_test application.tests.owasp_api_top10_2023_parser_test application.tests.owasp_llm_top10_2025_parser_test application.tests.owasp_top10_2025_parser_test application.tests.owasp_kubernetes_top10_2022_parser_test application.tests.owasp_kubernetes_top10_2025_parser_test application.tests.cheatsheets_parser_testMade with Cursor