#195: Sanitize recipient identifier in Maestro notification#202
Merged
rimi-itk merged 3 commits intoOS2Forms:masterfrom Oct 20, 2025
Merged
Conversation
rimi-itk
approved these changes
Aug 29, 2025
This was referenced Sep 1, 2025
stankut
reviewed
Sep 10, 2025
| // Remove all non-digits from recipient identifier. | ||
| $recipientIdentifier = preg_replace('/[^\d]+/', '', $recipient); | ||
|
|
||
| $recipientLookupResult = $this->digitalPostHelper->lookupRecipient($recipientIdentifier); |
Collaborator
There was a problem hiding this comment.
I have a suggestion which is related directly with the changed lines:
- it makes sense to explain in the doc what parameter is expected/allowed MaestroHelper.php#L359
stankut
reviewed
Sep 10, 2025
Collaborator
stankut
left a comment
stankut
left a comment
There was a problem hiding this comment.
all good, but a small comment/question from me.
ds-bellcom
added
the
Incl. in the next release
rimi-itk
deleted the
hotfix/195-maestro-notication-recipient-santizing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #195.
Important
This PR is currently aimed at the master branch since the develop branch is many features ahead and a potential patch version should be without these features.