Exit with error code 1 when verification fails#76
Open
linehill wants to merge 3968 commits intoORNL:masterfrom
Open
Exit with error code 1 when verification fails#76linehill wants to merge 3968 commits intoORNL:masterfrom
linehill wants to merge 3968 commits intoORNL:masterfrom
Conversation
…e issue is described in oneapi-src/SYCLomatic#559
[word2vec] rename word2vec variants to make the naming consistent
… header files; all GPU thread block sizes are 256; delete any BLAS library codes; the compiler option fastmath is enabled by default; the SYCL queue is an out-of-order queue; call the SYCL sincos() function instead of the sin() and cos() functions for performance portability in nbodyfft.cpp
…e argument; fix compiler warnings about comparison of integer expressions of different signedness; update the Makefile for the icpx compiler
…h a function pointer
…__host__ function `malloc` in __host__ __device__ function
…lvm#4595 for compiling the SYCL program; optimize the CUDA and HIP programs with the compile-time values of M, N and K variables mentioned in https://github.com/zjin-lcf/HeCBench/pull/70; change the variable name from P to K
…than needed reported in https://github.com/zjin-lcf/HeCBench/pull/72; slightly modify the loop count for computing the maximum value
Fix bspline-vgh thread block count in CUDA and HIP versions. Their block count was 256 times more than needed.
[bspline-vgh] fix bspline-vgh's thread block count in CUDA and HIP versions. Their block count was 256 times more than needed.
…s because the SYCL version is non-blocking copies. The issue is reported in https://github.com/zjin-lcf/HeCBench/pull/74
Make a lot of benchmarks to exit with error code 1 when the verification fails and make autohecbench.py skip result recording for the failing benchmarks. This commit is extended version of the [commit](franz@7a7f935) started by @franz. Co-authored-by: Henry Linjamäki <henry.mikael.linjamaki@intel.com>
Collaborator
|
I appreciate your changes. I am concerned about memory leaks for early exit. I will try to update all programs. |
Author
OS should take care of reclaiming the memory that is not freed by programs (link). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a lot of benchmarks to exit with error code 1 when the verification fails and make autohecbench.py skip result recording for the failing benchmarks.
(This commit is extended version of the commit started by @franz.)