ACTIVSg2000, ACTIVSg10k, Hawaii, IEEE39 Validation Data - #564
Conversation
2651008 to
2cf81d3
Compare
|
Once this is merged, we should be able to remove the older cases from |
2cf81d3 to
d443851
Compare
b97ed93 to
f16f381
Compare
|
@nkoukpaizan This one is ready! |
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("study", type=Path) | ||
| parser.add_argument("--rundir", type=Path) | ||
| parser.add_argument("--outdir", type=Path) |
There was a problem hiding this comment.
I'm debating whether to include this python code or not. At a minimum, we'd want some usage documentation and error handling for incorrect arguments.
There was a problem hiding this comment.
Your call, I threw it in just so the style of the plots stays consistent. I don't have a preference
There was a problem hiding this comment.
It's good to have. Please add some documentation (description/examples for the expected arguments). It wasn't obvious to me that study was the solver.json file.
f16f381 to
f799123
Compare
f799123 to
76b1c51
Compare
abirchfield
left a comment
There was a problem hiding this comment.
Just rename the ACTIVSg10k case in the documentation for clarity.
Otherwise looks good.
|
@nkoukpaizan ready! |
Description
Validation data (and updated cases with supported models) for ACTIVSg2000, ACTIVSg10k, Hawaii, IEEE39.
Proposed changes
cases/in clean, maintainable formatChecklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Major success. PowerWorld doesn't expose controls to lower the network solution below

1e-5tolerance, so I think we are nearing the tightest validation error we can get with the PowerWorld reference.