Open
Conversation
peter-spencer-ons
requested changes
Mar 19, 2026
Contributor
peter-spencer-ons
left a comment
peter-spencer-ons
left a comment
There was a problem hiding this comment.
Left a couple of comments
|
|
||
| echo "RUNNING: STAGE 1" | ||
| "$SCRIPT_DIR"/stage_1_add_semantic_search.py -n "STG1" -b "$batch_size" "$input_csv" "$input_metadata_json" "$output_folder" | ||
| "$SCRIPT_DIR"/stage_1_add_semantic_search.py -r -n "STG1" -b "$batch_size" -i "$input_file" -m "$input_metadata_json" -o "$output_folder" |
Contributor
There was a problem hiding this comment.
Do we want the default to use the restart (-r flag) parameter? If so, why not in stages 4 and further?
Contributor
peter-spencer-ons
left a comment
peter-spencer-ons
left a comment
There was a problem hiding this comment.
left a comment within the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
Make sure the metadata are used through out the evaluation pipeline.
📜 Changes Introduced
Update argument parsing and how it is propagated into the metadata.
Make default values more transparent and capture them in metadata.
Some params (such as model_location) were not used, fix that.
To gain control over parameters for embedding and to enable classifai test, refactor the STAGE1 script use class instance instead of going through API.
Instruction on how to run the pipeline updated accordingly.
✅ Checklist
terraform fmt&terraform validate)🔍 How to Test
Run the pipeline (as per readme instructions) on a small test data.
Please test checkpoints by interrupting and restarting.