Added run command in makefile - #70
Closed
delterr wants to merge 3 commits into
Closed
Conversation
Author
|
not ready to merge yet as i had set the command to specifically run to ons_python but need to generalise to all module names with jinja |
Comment on lines
+41
to
+43
| .PHONY: run | ||
| run: ## Run the application | ||
| poetry run python {{module_name}} |
Collaborator
There was a problem hiding this comment.
Thanks for the PR.
-
This is the wrong file; you need to add this to https://github.com/ONSdigital/ons-python-template/blob/main/project_template/Makefile.jinja (templates makefile, not this repo's root template)
-
You also need to make it agnostic to the package manager, so it should be:
{{ package_manager }} run python {{ module_name }}- Please add this new
__main__.pyfile to https://github.com/ONSdigital/ons-python-template#structure
Comment on lines
+1
to
+8
| from calculator import Calculator | ||
| calc = Calculator() | ||
|
|
||
| calc.add(5) | ||
|
|
||
| calc.subtract(2) | ||
|
|
||
| print(calc.cumulative_total) |
Collaborator
There was a problem hiding this comment.
This would currently raise lint failures.
Suggested change
| from calculator import Calculator | |
| calc = Calculator() | |
| calc.add(5) | |
| calc.subtract(2) | |
| print(calc.cumulative_total) | |
| from calculator import Calculator | |
| calc = Calculator() | |
| calc.add(5) | |
| calc.subtract(2) | |
| print(calc.cumulative_total) | |
Collaborator
|
@delterr If you address the above comments, we can progress this |
Collaborator
|
Closing the PR due to inacivity and the following PR superseeding the current one: #114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #69