feature/new platform integration#177
Open
418error wants to merge 7 commits into
Open
Conversation
- This introduces `eks session` subcmds this has been structured to potentially add more `eks`` cmds as we need them - `start` will locate the bastion and auto discover available clusters to setup port forwarding to - `stop` will terminate any running or dead sessions and clean up tmp files - `status` shows the current status of the connections
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
lindenmckenzie
left a comment
lindenmckenzie
left a comment
There was a problem hiding this comment.
I have gone through all the code - nothing looks massively out of place but equally that's a lot to go through. Largely seems sensibly structured and well documented. I have left a couple of very minor comments for documentation, once it has the supporting infrastructure in place I would be interested to test it in anger.
… for getAWSConfig
- Added OS compatibility to eks tunnel and sudo util, allowing support for Linux in addition to macOS. The EnsureLoopbackAlias function now handles loopback alias creation for both operating systems, and FlushDNSCache performs best-effort flushing based on the detected OS. This enhancement broadens the usability of the EKS tunneling features across different development environments. - CheckAPIConnectivity now uses a simple TCP dial to the EKS API endpoint on port 443 instead of an HTTPS request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change is to add support for the new EKS platforms and remote access lambda.
remote2subcmd the new centrally audited remote allow lambdaekssubcmds for creating session tunnels to EKS via the bastion jump boxesHow to review
This can be reviewed in the context of the other supporting infrastructure changes,
speak tot he platform team for enrolling on to the new clusters.
Who can review
!me