refactor: move stat-pill state colors into CSS modules#406
Merged
Conversation
Replace conditional inline color styles in UnitsTab and StatsTab stat pills with semantic modifier classes (detailStatValueKills/Deaths/ Markers, forceStatNumTotal/Alive/Kills/Deaths). Keeps JSX free of state-driven inline color logic.
Coverage Report for ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the styling of statistics in the recording playback side panel by moving inline styles into dedicated CSS classes within SidePanel.module.css and updating StatsTab.tsx and UnitsTab.tsx to utilize these classes. This change improves maintainability and consistency across the UI. One improvement opportunity was identified regarding a hardcoded hex color that should be replaced with a CSS variable to maintain themeability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnitsTabandStatsTabstat pills with semantic CSS module classes.detailStatValueKills/Deaths/MarkersandforceStatNumTotal/Alive/Kills/Deathson the existing base classes; default color falls back to--text-dimmest.Test plan
npx vitest run src/pages/recording-playback/ src/hooks/__tests__/useCustomize.test.tsx(320 tests pass)npx tsc --noEmit