Skip to content

[18.0][IMP] queue_job: Implement on fail hook - #971

Merged
OCA-git-bot merged 3 commits into
OCA:18.0from
camptocamp:18-on-fail-hook
Sep 1, 2026
Merged

[18.0][IMP] queue_job: Implement on fail hook#971
OCA-git-bot merged 3 commits into
OCA:18.0from
camptocamp:18-on-fail-hook

Conversation

@simahawk

@simahawk simahawk commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of

Allows to execute a model function when the job fails and will not be retried.

@grindtildeath @simahawk
[IMP] queue_job: Implement on fail hook
0e56e44 
Allows to execute a model function when the job fails and will
not be retried.

[REF] queue_job: Move on fail definition to job function

Rename on_fail_hook to on_fail
@OCA-git-bot

OCA-git-bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Hi @guewen, @sbidoul,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:queue_job Module queue_job mod:test_queue_job Module test_queue_job series:18.0 labels Aug 27, 2026
@simahawk simahawk mentioned this pull request Aug 27, 2026
Open
SilvioC2C
SilvioC2C approved these changes Aug 27, 2026
View reviewed changes

@SilvioC2C SilvioC2C left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Comment thread queue_job/tests/test_run_rob_controller.py Outdated
@Ricardoalso

Ricardoalso commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

FIX for this feature in 19.0 #974

@simahawk

simahawk commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

TODO backport #974

@Ricardoalso @simahawk
[FIX] queue_job: skip on_fail when unconfigured
2a49b4b 
Job.on_fail_method_name was only set as an instance attribute when
the job function configured on_fail_method, so on_fail() raised
AttributeError for every job that didn't opt into it.
@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

TODO backport #974

done

@oca-cla-bot

oca-cla-bot Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

The following commit authors need to sign the Contributor License Agreement:

* [simahawk@gmail.com](mailto:simahawk@gmail.com)

CLA not signed

WHAT? 😄

@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@Ricardoalso to cherry-pick to 19 2f7a155

@sbidoul

sbidoul commented Sep 1, 2026

Copy link
Copy Markdown
Member

@simahawk apparently none of your two contacts in the OCA database have the ICLA tag (nor ECLA for that matter).

Good opportunity to click and test our shiny new CLA bot :)

@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@simahawk apparently none of your two contacts in the OCA database have the ICLA tag (nor ECLA for that matter).

Good opportunity to click and test our shiny new CLA bot :)

Let's try it 😄

It starts w/ a short list of repos that I don't know if it makes sense

image

Shall I open a thread somewhere else?

@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

I went through the process and it worked on the fly. Nice :)
Yet, it's strange because here the message says that everything was fine before I did it 🤔

All commit authors signed the Contributor License Agreement.

CLA signed

@simahawk

simahawk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-971-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit c57db4d into OCA:18.0 Sep 1, 2026
8 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 97b3ad2. Thanks a lot for contributing to OCA. ❤️

@sbidoul

sbidoul commented Sep 1, 2026

Copy link
Copy Markdown
Member

I went through the process and it worked on the fly. Nice :)

@simahawk 👍

It starts w/ a short list of repos that I don't know if it makes sense

Yes it's correct. We enabled it on some repos for a pilot phase. If you want it activated on other repos you maintain, just let me know. At this point we determined that many past contribs were accepted under ECLA without ICLA so we need to think what to do about that.

Yet, it's strange because here the message says that everything was fine before I did it 🤔

How so? Your signature was created at Sept. 1, 2026, 1:40 p.m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewen guewen guewen approved these changes
+1 more reviewer
@SilvioC2C SilvioC2C SilvioC2C approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:queue_job Module queue_job mod:test_queue_job Module test_queue_job series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@simahawk @OCA-git-bot @Ricardoalso @sbidoul @guewen @SilvioC2C @grindtildeath