Skip to content

[18.0][MIG] attachment_preview: Migration to 18.0#552

Merged
OCA-git-bot merged 39 commits intoOCA:18.0from
ByteMeAsap:18.0-mig-attachment_preview
Dec 31, 2025
Merged

[18.0][MIG] attachment_preview: Migration to 18.0#552
OCA-git-bot merged 39 commits intoOCA:18.0from
ByteMeAsap:18.0-mig-attachment_preview

Conversation

@ByteMeAsap
Copy link
Contributor

@ByteMeAsap ByteMeAsap commented Jul 15, 2025

No description provided.

hbrunn and others added 15 commits July 3, 2025 17:42
@hbrunn @ByteMeAsap
[ADD] preliminary port of attachment_preview
2ead898
@hbrunn @ByteMeAsap
[IMP] have titles work everywhere
8379e03
@hbrunn @ByteMeAsap
[FIX] don't depend on document, the relevant code still lives in web
e3ce9fc
@hbrunn @ByteMeAsap
[ADD] translations
9224f52
@hbrunn @ByteMeAsap
[UPD] use viewerJS 0.5.4, incorporate new suported file types
0a31de8
@hbrunn @ByteMeAsap
[FIX] readme 8.0 style
659a484
@gurneyalex @ByteMeAsap
Add OCA as author of OCA addons
7e3ed8c 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@gurneyalex @ByteMeAsap
fix travis (flake8)
197dc3c
@sysadminmatmoz @ByteMeAsap
Slovene translations added
d846ea0
@hbrunn @ByteMeAsap
[UPD] use viewerjs 0.5.7
6622bfc
@sysadminmatmoz @ByteMeAsap
Translations and templates sync
5d73bc0
@sbidoul @ByteMeAsap
[UPD] prefix versions with 8.0
a743216
@pedrobaeza @ByteMeAsap
[MIG] Make modules uninstallable
5a69211
@pedrobaeza @ByteMeAsap
[MIG] Rename manifest files
989e557
@sbidoul @ByteMeAsap
remove obsolete .pot files [ci skip]
463a2b5
@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch 15 times, most recently from 5a9e1bc to 4675660 Compare July 15, 2025 07:22
weblate and others added 5 commits December 22, 2025 10:04
@weblate @ByteMeAsap
Update translation files
1ce81c4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/
@luis-ron @ByteMeAsap
Translated using Weblate (Spanish)
2a74a6d 
Currently translated at 100.0% (4 of 4 strings)

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/es/
@mymage @ByteMeAsap
Translated using Weblate (Italian)
3bb24e2 
Currently translated at 100.0% (4 of 4 strings)

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/it/
@weblate @ByteMeAsap
Update translation files
4f0bf1e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-15.0/knowledge-15.0-attachment_preview
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/
@ByteMeAsap
[IMP] attachment_preview: pre-commit auto fixes
ba7e2f5
@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from 8470908 to 52934ee Compare December 22, 2025 04:34
@ByteMeAsap
Copy link
Contributor Author

ByteMeAsap commented Dec 22, 2025

@ByteMeAsap thank you for your contribution! Please squash the last two commits. Also please squash all the administrative commits with the [UPD] tag if you feel comfortable to do this.
Done !!

tendil
tendil suggested changes Dec 24, 2025
View reviewed changes
Copy link

@tendil tendil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByteMeAsap thank you for your contribution!
Please check my comments

Aldeigja
Aldeigja reviewed Dec 24, 2025
View reviewed changes
Copy link

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files.
Tested on version 14, it works there.

@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from 52934ee to b7f83ed Compare December 26, 2025 10:24
@ByteMeAsap
Copy link
Contributor Author

ByteMeAsap commented Dec 26, 2025

@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files. Tested on version 14, it works there.

The preview does work for LibreOffice files, the problem is it doesn't do that unless the attachmentlist is reloaded after uploading the file

tendil
tendil approved these changes Dec 26, 2025
View reviewed changes
Copy link

@tendil tendil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from b7f83ed to a3a32c1 Compare December 28, 2025 06:07
@ByteMeAsap
Copy link
Contributor Author

ByteMeAsap commented Dec 28, 2025

@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files. Tested on version 14, it works there.

Show work fine now

@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from a3a32c1 to 4c76d71 Compare December 28, 2025 06:33
@Aldeigja
Copy link

Aldeigja commented Dec 30, 2025

@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files. Tested on version 14, it works there.
Show work fine now

Hi @ByteMeAsap
I've just tested it, I uploaded LibreOffice file, refreshed page, clicked on the magnifying glass icon and got an error:

Odoo Client Error

UncaughtClientError > TypeError
Uncaught Javascript Error > Cannot read properties of undefined (reading 'filter')

Occured on oca-knowledge-18-0-pr552-4c76d71001bc.runboat.odoo-community.org on 2025-12-30 05:31:59 GMT

TypeError: Cannot read properties of undefined (reading 'filter')
    at AttachmentList._onPreviewAttachment (http://oca-knowledge-18-0-pr552-4c76d71001bc.runboat.odoo-community.org/web/assets/4f1eee0/web.assets_web.min.js:18381:604)
    at AttachmentList.hdlr4 (eval at compile (http://oca-knowledge-18-0-pr552-4c76d71001bc.runboat.odoo-community.org/web/assets/4f1eee0/web.assets_web.min.js:1585:421), <anonymous>:107:39)
    at Object.mainEventHandler (http://oca-knowledge-18-0-pr552-4c76d71001bc.runboat.odoo-community.org/web/assets/4f1eee0/web.assets_web.min.js:1638:77)
    at HTMLButtonElement.listener (http://oca-knowledge-18-0-pr552-4c76d71001bc.runboat.odoo-community.org/web/assets/4f1eee0/web.assets_web.min.js:782:15)

Could you please take a look?

@ByteMeAsap ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from 4c76d71 to a62e036 Compare December 30, 2025 06:43
@ByteMeAsap
Copy link
Contributor Author

ByteMeAsap commented Dec 30, 2025

Could you please take a look?

@Aldeigja , thanks for reporting this, should be fixed now

Aldeigja
Aldeigja approved these changes Dec 31, 2025
View reviewed changes
Copy link

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 31, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Dec 31, 2025

@ByteMeAsap thank you for your contribution!
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 31, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-552-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 31, 2025

Congratulations, your PR was merged at 9921245. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 6c63999 into OCA:18.0 Dec 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix left review comments

+2 more reviewers

@tendil tendil tendil approved these changes

@Aldeigja Aldeigja Aldeigja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.