-
Notifications
You must be signed in to change notification settings - Fork 29
docs: adds a clarification for different formats across documents #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
Overlays are not restricted to an OAD. They can be applied to any JSON/YAML document. That should be clearly defined and allowed |
|
I disagree @jeremyfiel - we are not committing to maintain a generic JSON updating tool here. In fact in the meetings we have discussed that we would like the Overlays to be more OpenAPI-aware, not more generic. |
|
@jeremyfiel :
If we want to expand the mandate of Overlays, it probably means a major overhaul of the specification itself. I'm not fundamentally opposed to that, but I think this is probably a v2 kind of thing. Not a v1.1. |
|
@lornajane I agree, Overlays can become more powerful for the OpenAPI ecosystem by leveraging knowledge of OAS/Arazzo syntax and semantics. JSON Patch and JSON Merge-Patch already exist as generic JSON modification systems. @baywet there might be some subtleties here if "OpenAPI Description" (the "D" should be capitalized) is used, as opposed to just any OpenAPI document (little "d"). Applying to a doccument is intuitive. But if we're applying to OADs, does that mean applying to an entry document applies to all documents reachable from that entry document? (AFAICT Overlays currently work on individual documents, my apologies if I am misunderstanding). |
|
@handrews you are correct, the overlays "don't understand" the semantics of Descriptions which can aggregate multiple documents. Or at least it's not clearly called out/buried under multiple layers of specifications. I think that if we could update the wording to say "this can apply to OpenAPI documents, JSON schemas (as a schema alone in a file), and OpenAPI document "fragments" (might have a different name, but I was under the impression we could leave an OpenAPI operation alone as a root node for reusability and it was a valid thing). We'd cover all the use cases of OpenAPI while refraining from expanding to "other use cases" which were clearly not the initial plan. Thoughts? |
fixes #260