#4511 competition performance - #4523
Merged
wavehassman merged 7 commits intoSep 20, 2026
Merged
Conversation
staysgt
self-requested a review
September 17, 2026 21:58
staysgt
requested changes
Sep 17, 2026
staysgt
left a comment
staysgt
left a comment
Contributor
There was a problem hiding this comment.
Looks really good so far!
| <UnderlinedLabel label="Worst Dynamic Event" value={performance.worstDynamicEvent ?? 'N/A'} /> | ||
| </Box> | ||
|
|
||
| <Box flex="1 1 140px" display="flex" justifyContent="center" alignItems="flex-start"> |
Contributor
There was a problem hiding this comment.
Instead of having total points set to zero if it doesn't exist, I think we should instead only display the donut graph if there are points to display. Same with the max points; only display the donut graph if totalPointsEarned and maxPoints are both defined
Comment on lines
+180
to
+183
| <StatBlock | ||
| value={`${performance.enduranceLapsCompleted ?? 'N/A'}/${PLACEHOLDER_MAX_ENDURANCE_LAPS}`} | ||
| label="Endurance Laps Completed" | ||
| /> |
Contributor
There was a problem hiding this comment.
For the endurance laps completed, if endurance laps is undefined and max laps is set, it will display something like: N/A/40, which is difficult to read. Instead we should only display this section if enduranceLapsCompleted is defined
…h 'origin/feature/executive-summary' into #4511-Competition-Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Created a competition performance component that meets the following criteria:
FSAE / FHE subtabs
renders final place, total points earned, best/worst static event, best/worst dynamic event, acceleration top time, endurance laps completed, autocross top time, endurance average lap time
Notes
The Width was hardcoded at 500px to emulate the size of the component on the full executive summary mock, This is noted in comments and will be easy to change if/when it needs to be.
I added a check to make sure that both endurance laps and max laps existed before rendering the text. Idea was that if i just checked for endurance laps it could result in something like 40/N/A which would've caused the same readability issue.
Test Cases
Tested to make sure it rendered placements properly e.g (1st, 2nd, 3rd, 4th, 11th, 12th, 21st)
Tested case where donut graph had no points to display
Tested case where endurance laps/ max laps were undefined.
Screenshots
Normal window size (FSAE):
Smallest window size:
FSAE tab:
FHE tab:
No wheel or endurance laps:
To Do
Closes #4511