Skip to content

#3923 - adding alternating shades#3931

Merged
chpy04 merged 6 commits intodevelopfrom
3923-Alternating-ColorShading-BOM
Feb 5, 2026
Merged

#3923 - adding alternating shades#3931
chpy04 merged 6 commits intodevelopfrom
3923-Alternating-ColorShading-BOM

Conversation

@Steph375
Copy link
Contributor

@Steph375 Steph375 commented Jan 28, 2026

Changes

Changed shading so it alternates per row of the BOM table. I also returned assembly to its original grey and just changed it to the same over color.

Screenshots

(with hover)
Screenshot 2026-02-01 194511

(without hover)
Screenshot 2026-02-01 194529

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3923

@Steph375 Steph375 changed the title adding alternating shades #3923 - adding alternating shades Jan 28, 2026
@Steph375 Steph375 self-assigned this Jan 28, 2026
@Steph375 Steph375 requested a review from chpy04 January 28, 2026 23:06
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not a huge fan of how bright the light boxes are, how when I hoverthe bright ones become darker but the darker ones become brighter, and how the assemblies which used to be visually distinct now kind of blend in. Can we use the same colors for alternating rows and hover highlighting as the change requests table (https://finishlinebyner.com/change-requests/all)? Then we can keep the assembly rows the same color they are now, and it would look a lot more cohesive with the rest of the site

@Steph375 Steph375 requested a review from chpy04 February 2, 2026 01:05
@chpy04 chpy04 merged commit 28cd945 into develop Feb 5, 2026
4 checks passed
@chpy04 chpy04 deleted the 3923-Alternating-ColorShading-BOM branch February 5, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Change color shading

2 participants