Skip to content

libphonenumber: unpin boost, fix build with boost 1.89#492413

Merged
wegank merged 1 commit intoNixOS:staging-nextfrom
thunze:libphonenumber-fix-boost-1.89
Feb 20, 2026
Merged

libphonenumber: unpin boost, fix build with boost 1.89#492413
wegank merged 1 commit intoNixOS:staging-nextfrom
thunze:libphonenumber-fix-boost-1.89

Conversation

@thunze
Copy link
Copy Markdown
Member

@thunze thunze commented Feb 20, 2026

Finding boost_system fails because the stub compiled library of Boost.System, which has been a header-only library since 1.69, was removed in 1.89.

Upstream PR: google/libphonenumber#3903

(As discussed in the Matrix Staging room)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Finding `boost_system` fails because the stub compiled library of
Boost.System, which has been a header-only library since 1.69, was
removed in 1.89 [1].

Upstream PR: google/libphonenumber#3903

[1] https://www.boost.org/releases/1.89.0/
@thunze thunze force-pushed the libphonenumber-fix-boost-1.89 branch from 1479033 to 479c683 Compare February 20, 2026 09:33
Copy link
Copy Markdown
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@nixpkgs-ci nixpkgs-ci Bot requested review from illegalprime and wegank February 20, 2026 09:42
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 20, 2026
@wegank wegank added this pull request to the merge queue Feb 20, 2026
Merged via the queue into NixOS:staging-next with commit da92ad4 Feb 20, 2026
35 of 37 checks passed
@thunze thunze deleted the libphonenumber-fix-boost-1.89 branch February 20, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants