Skip to content

Conversation

@thunze
Copy link
Member

@thunze thunze commented May 3, 2025

Hydra: https://hydra.nixos.org/build/294880588/nixlog/2

  • A test currently fails on Python 3.13 due to a change in the default behavior of ast.dump.
  • Submitted a patch upstream.
  • Added the patch to the Nix package for now to fix the build.

Upstream patch: samuelcolvin/python-devtools#166

ZHF: #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 3, 2025
@thunze
Copy link
Member Author

thunze commented May 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404022


x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python313Packages.vllm
  • python313Packages.vllm.dist
  • vllm
  • vllm.dist
✅ 8 packages built:
  • python312Packages.devtools
  • python312Packages.devtools.dist
  • python312Packages.prometheus-fastapi-instrumentator
  • python312Packages.prometheus-fastapi-instrumentator.dist
  • python313Packages.devtools
  • python313Packages.devtools.dist
  • python313Packages.prometheus-fastapi-instrumentator
  • python313Packages.prometheus-fastapi-instrumentator.dist

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 3, 2025
@nix-owners nix-owners bot requested a review from jdahm May 3, 2025 23:42
@Sigmanificient Sigmanificient added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 4, 2025
@Aleksanaa Aleksanaa merged commit 5c4f9f9 into NixOS:master May 4, 2025
26 of 27 checks passed
@thunze thunze deleted the fix-devtools branch May 4, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants